-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: translate trix field controller js warnings #3330
feature: translate trix field controller js warnings #3330
Conversation
Code Climate has analyzed commit 0a401e4 and detected 0 issues on this pull request. View more on Code Climate. |
@Paul-Bob Your steps to implement the feature worked great! I added the translation for the others 2 warnings that I found there. Can you help with the tests if necessary for this change? |
Hey @rafaeliga thank you for the contribution, is looking great! We already have some tests for the trix field on That test is already a system test and you should be able to test this alerts inside it. |
@Paul-Bob Do you use VS code? I see that the project uses Ruby LSP, but I think its missing something to configure here: |
Yes, I'm not sure why that is happening on your side. |
@Paul-Bob Which page should I add documentation? Maybe this one? https://docs.avohq.io/3.0/i18n.html#customize-the-locale |
Let's add a new section on the Trix field docs (https://docs.avohq.io/3.0/fields/trix.html) and specify the supported translation keys and when/where those are used. |
0ca6877
to
59bb830
Compare
@Paul-Bob Looks good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for this contribution @rafaeliga!
Description
Translates trix_field_controller js warnings
Fixes #3329
Checklist:
Screenshots & recording
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.
Documentation
avo-hq/docs.avohq.io#301