-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: undefined tags in field when editing #3315
fix: undefined tags in field when editing #3315
Conversation
Code Climate has analyzed commit 2af81ca and detected 0 issues on this pull request. View more on Code Climate. |
Hey @coatezy thanks for the contribution! I noticed that some tests are failing. Could you please share the tags field code from your resource and more details about how to reproduce the issue? |
Hey, @Paul-Bob! Not problem. I'd be happy to try and understand why these are failing. The tags field is configured in the following way on the resource.
|
I was able to reproduce the issue, I guess the tests are failing because tags cover several use cases and this change fixes this particular use case but maybe is breaking another use case, I'll also have a look |
62be726
to
851affa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested some changes that might be effective.
When using suggestions
https://docs.avohq.io/3.0/fields/tags.html#possible-values as an array of hashes the possibleSuggestion
will respond to label
but when used as array of values or not used at all it will NOT respond to label
This PR has been marked as stale because there was no activity for the past 15 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution @coatezy!
Some tests were failing, so I made a change to ensure that tags function correctly in other scenarios.
Description
This PR fixes an undefined tag issue when editing existing tags on a resource.
Checklist:
Screenshots & recording
Before:
After:
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.