-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sorting for key value fields #3299
Add sorting for key value fields #3299
Conversation
Code Climate has analyzed commit 53c4d23 and detected 0 issues on this pull request. View more on Code Climate. |
@adrianthedev @Paul-Bob it should be ready :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Thank you @enderahmetyurt for this contribution!
This is great @enderahmetyurt! Awesoem work! There's only one thing I'd like to do more. Thanks for working on this. |
good idea thanks @adrianthedev. Wdty? |
Co-authored-by: Paul Bob <[email protected]>
7d2b5c5
to
8192332
Compare
@adrianthedev @Paul-Bob I added enderahmetyurt#1 solution to here. wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better with the DnD! Thank you for your effort on this @enderahmetyurt!
…metyurt/avo into feature/reorder-key-value-fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all your effort on this contribution @enderahmetyurt. It turned out great!
I fixed a bug in the drag-and-drop logic that was swapping elements instead of inserting the dragged element in the intended drop location.
Additionally, I added localization support for the reorder title and refactored the label getters.
@enderahmetyurt could you please update de description since the text and video are outdated? Thank you! |
Thank you very much @Paul-Bob I'll update the description of this PR |
Description
Adding reorder row button to sort key-value fields.
Fixes #1029
Checklist:
Screenshots & recording
Screen.Recording.2024-11-05.at.08.03.26.mov