Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no link on breadcrumb when visiting from an association #3226

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Sep 6, 2024

Description

Fixes #3222

Make parent table breadcrumb not clickable when visiting from associations since it was "not part of the journey".

  1. Go to Users resource
  2. Click on Joane Bednar

Scroll to projects tab and click show on Bytecard

image

Scroll to projects tab and click edit on Bytecard

image

Scroll to projects tab and click "New Project"

image

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob marked this pull request as draft September 6, 2024 10:45
Copy link

codeclimate bot commented Sep 6, 2024

Code Climate has analyzed commit 1b3fcc1 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions github-actions bot added the Fix label Sep 6, 2024
@Paul-Bob Paul-Bob self-assigned this Sep 6, 2024
@Paul-Bob Paul-Bob marked this pull request as ready for review September 6, 2024 10:53
@adrianthedev adrianthedev changed the title fix: breadcrumb when visit show from association fix: no link on breadcrumb breadcrumb when visiting from an association Sep 6, 2024
Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"make coherent"

@Paul-Bob Paul-Bob changed the title fix: no link on breadcrumb breadcrumb when visiting from an association fix: no link on breadcrumb when visiting from an association Sep 9, 2024
…hub.com:avo-hq/avo into fix/breadcrumb_when_visit_show_from_association
@Paul-Bob Paul-Bob merged commit 4e38e0d into main Sep 12, 2024
22 checks passed
@Paul-Bob Paul-Bob deleted the fix/breadcrumb_when_visit_show_from_association branch September 12, 2024 12:40
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breadcrumb: exclude nested INDEX resource
2 participants