Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: apply show policy on click_row_to_view_record #3213

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Sep 3, 2024

Description

Fixes #3200

Apply show? policy on click_row_to_view_record feature. If show? returns false then the row should not be clickable.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added the Fix label Sep 3, 2024
@Paul-Bob Paul-Bob self-assigned this Sep 3, 2024
Copy link

codeclimate bot commented Sep 3, 2024

Code Climate has analyzed commit 2978638 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob changed the title fix: apply show policy on click_row_to_view_record feature: apply show policy on click_row_to_view_record Sep 3, 2024
@Paul-Bob Paul-Bob added Feature and removed Fix labels Sep 3, 2024
@Paul-Bob Paul-Bob merged commit 4f318a8 into main Sep 5, 2024
22 checks passed
@Paul-Bob Paul-Bob deleted the fix/apply_policy_on_click_row_to_view_record branch September 5, 2024 07:42
Copy link
Contributor

github-actions bot commented Sep 5, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If the Show page is disabled, the click_row_to_view_record link should not be enabled
2 participants