Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: constantize model_class on reader #3207

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Sep 3, 2024

Description

Fixes #3191

Constantize the model_class on reader instead of on writer.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added the Fix label Sep 3, 2024
@Paul-Bob Paul-Bob self-assigned this Sep 3, 2024
@Paul-Bob Paul-Bob changed the title fix: constantize model_class on demand fix: constantize model_class on reader Sep 3, 2024
Copy link

codeclimate bot commented Sep 3, 2024

Code Climate has analyzed commit 294a3ea and detected 0 issues on this pull request.

View more on Code Climate.

lib/avo/resources/base.rb Outdated Show resolved Hide resolved
lib/avo/resources/base.rb Outdated Show resolved Hide resolved
lib/avo/resources/base.rb Outdated Show resolved Hide resolved
lib/avo/resources/base.rb Outdated Show resolved Hide resolved
lib/avo/resources/base.rb Outdated Show resolved Hide resolved
lib/avo/resources/base.rb Outdated Show resolved Hide resolved
lib/avo/resources/base.rb Outdated Show resolved Hide resolved
lib/avo/resources/base.rb Outdated Show resolved Hide resolved
lib/avo/resources/base.rb Outdated Show resolved Hide resolved
lib/avo/resources/base.rb Outdated Show resolved Hide resolved
lib/avo/resources/base.rb Outdated Show resolved Hide resolved
lib/avo/resources/base.rb Outdated Show resolved Hide resolved
lib/avo/resources/base.rb Outdated Show resolved Hide resolved
lib/avo/resources/base.rb Outdated Show resolved Hide resolved
@adrianthedev adrianthedev merged commit ab9ead7 into main Sep 3, 2024
22 checks passed
@adrianthedev adrianthedev deleted the fix/constantize_model_class_on_demand branch September 3, 2024 10:09
Copy link
Contributor

github-actions bot commented Sep 3, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constantize model_class when requested, not on initialization
2 participants