[2.x] Remove last usage of _reflections in favor of reflect_on_association. #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- better compatible with newer Rails, since it casts to needed type on its own
|
I'm not 100% sure the CI failure is related to the change, I have seen same problem in other PR without this change also. 🤔 |
|
Thanks for looking into this.
I'll have a look. Is this still a draft? |
|
@Paul-Bob it is draft, since I wasn't able to get passing CI. Code-wise looks ok to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
successor to #2927
I'm trying to setup Rails 7.2 for Avo 2.x CI at #3204 as well, but it will probably need more time.