Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further updates for rails 7.2 #3184

Closed
wants to merge 1 commit into from
Closed

Conversation

jpawlyn
Copy link
Contributor

@jpawlyn jpawlyn commented Aug 23, 2024

Description

Follow on from #2927 to make 2.x more compitable with Rails 7.2

Fixes # (issue)

Failure/Error: reflected_model = reflection.klass
     
     NoMethodError:
       undefined method `klass' for nil
     # /Users/jpawlyn/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/avo-2.52.0/app/controllers/avo/application_controller.rb:231:in `related_resource'
     # /Users/jpawlyn/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/avo-2.52.0/app/controllers/avo/application_controller.rb:126:in `set_related_resource'
     # /Users/jpawlyn/.rbenv/versions/3.3.4/lib/ruby/gems/3.3.0/gems/activesupport-7.2.1/lib/active_support/callbacks.rb:362:in `block in make_lambda'

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@jpawlyn
Copy link
Contributor Author

jpawlyn commented Aug 26, 2024

I can see there are 2 failing tests. Let me try debugging them

@jpawlyn
Copy link
Contributor Author

jpawlyn commented Aug 26, 2024

I can't seem to get the tests to pass so closing for now

@jpawlyn jpawlyn closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant