Fix belongs_to and ID field linking to child resources if configured
#3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 93c1117 and detected 0 issues on this pull request. View more on Code Climate. |
stevegeek
commented
Aug 8, 2024
|
@Paul-Bob @adrianthedev , if there is anything I can do to help you guys with reviewing this PR, do let me know |
|
I'm reviewing it, thank you @stevegeek |
Paul-Bob
reviewed
Aug 14, 2024
There was a problem hiding this comment.
I added a comment to cover the for_attribute scenario, otherwise, it's looking great @stevegeek! Thank you!
app/components/avo/base_component.rb
Outdated
|
|
||
| @resource.link_to_child_resource | ||
| end | ||
|
|
||
| def field_linked_to_child_resource? | ||
| field.present? && field.respond_to?(:link_to_child_resource) && field.link_to_child_resource | ||
| resolved_field = @reflection ? @parent_resource.get_field(@reflection.name) : field |
There was a problem hiding this comment.
I guess this will not find the field when using for_attribute option. For example:
field :the_children, as: :has_many, for_attribute: :children, link_to_child_resource: trueThis should cover that scenario, can you please verify that?
Suggested change
| resolved_field = @reflection ? @parent_resource.get_field(@reflection.name) : field | |
| resolved_field = @reflection ? @parent_resource.get_field(params[:for_attribute] || @reflection.name) : field |
Paul-Bob
reviewed
Aug 14, 2024
| @@ -19,6 +27,36 @@ | |||
| end | |||
| end | |||
|
|
|||
| context "Resource show page links to associated resources" do | |||
| let(:paul) { create :sibling, name: "paul" } | |||
|
Thanks @stevegeek. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a resource includes a
belongs_tofield which relates to a record which uses STI, then the current behaviour is that the link rendered on theshowpage for the resource to the associated record always links to the parent class resource. In other places this behaviour is controlled bylink_to_child_resourcebut not here.Related, if
id_links_to_resourceis used andlink_to_child_resourceis set for an association, the link does not respect thelink_to_child_resourcesetting.This PR updates the
belongs_tofield to respect thelink_to_child_resourceoption, which can either be set on the Resource, or set on the field.It also changes the way BaseComponent determines if a field should
link_to_child_resourceby using the association reflection and checking the related association.I believe this fixes #2629 and fixes #2782
Checklist:
Screenshots & recording
I have checked this in an application using Avo but can't share screenshots from it.
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.