Feature: Add breadcrumbs to association pages #3082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 1496282 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
binarygit
force-pushed
the
add-breadcrumbs-to-assoc-pages
branch
from
1277b1c
to
958f253
Compare
binarygit
force-pushed
the
add-breadcrumbs-to-assoc-pages
branch
from
958f253
to
a63d924
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
binarygit
force-pushed
the
add-breadcrumbs-to-assoc-pages
branch
from
7f1ef79
to
1bb8798
Compare
Paul-Bob
requested changes
Aug 2, 2024
There was a problem hiding this comment.
Association tables are broken when loading a team page
Also lets ensure tests are passing
adrianthedev
requested changes
Aug 6, 2024
adrianthedev
reviewed
Aug 6, 2024
Paul-Bob
requested changes
Aug 6, 2024
adrianthedev
reviewed
Aug 6, 2024
Co-authored-by: Paul Bob <[email protected]>
|
This PR has been merged into Please check the release guide for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users open "attachment" pages, like the model for attaching a team member, as standalone pages we need to display breadcrumbs. This PR adds those breadcrumbs to such pages.
Description
Fixes #3062
Checklist:
Screenshots & recording
When navigating to the team_members page from Teams:
When navigating to the teams page from Users:
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.