Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base resource overriding #3077

Merged
merged 23 commits into from
Aug 5, 2024
Merged

fix: base resource overriding #3077

merged 23 commits into from
Aug 5, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jul 31, 2024

Description

Fixes #3073

Base resource extension was not possible with the Avo::BaseResource on lib/avo/base_resource.rb path.

This PR moves lib/avo/base_resource.rb to app/avo/base_resource.rb and adds the engine's directory app/avo to autoloaders.

ActiveSupport::Dependencies.autoload_paths.delete(directory_path) is only necessary for Rails lower than 7.1. For more context check fxn/zeitwerk#250 (comment)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    • Docs are already according to this configuration
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added the Fix label Jul 31, 2024
@Paul-Bob Paul-Bob self-assigned this Jul 31, 2024
Copy link

codeclimate bot commented Jul 31, 2024

Code Climate has analyzed commit 114c121 and detected 0 issues on this pull request.

View more on Code Climate.

spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
spec/features/avo/resource_extension_spec.rb Outdated Show resolved Hide resolved
lib/avo/engine.rb Outdated Show resolved Hide resolved
lib/avo/engine.rb Outdated Show resolved Hide resolved
lib/avo/engine.rb Show resolved Hide resolved
Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Paul-Bob Paul-Bob merged commit 4c50e08 into main Aug 5, 2024
22 checks passed
@Paul-Bob Paul-Bob deleted the fix/base_resource_overriding branch August 5, 2024 09:29
Copy link
Contributor

github-actions bot commented Aug 5, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix base resource extending
2 participants