refactor: reflect_on_association instead _reflections
#3069
Conversation
|
Code Climate has analyzed commit 72bfc37 and detected 0 issues on this pull request. View more on Code Climate. |
| @@ -188,5 +188,9 @@ def join_record | |||
| reflection.through_reflection.klass.find_by(source_foreign_key => @attachment_record.id, | |||
| through_foreign_key => @record.id) | |||
| end | |||
|
|
|||
| def has_many_reflection? | |||
| reflection_class.in? ["HasManyReflection", "HasAndBelongsToManyReflection"] | |||
There was a problem hiding this comment.
I noticed that above some mentions are classes and these are strings.
Is there anything we can do to make them the same or do we have to know when to call as a string and as a class?
There was a problem hiding this comment.
Makes sense. There is no reason to use class.name.demodulize.to_s and check against a string.
|
Also, let's link the Avo 2 PR as well here for reference. |
| @@ -188,5 +188,9 @@ def join_record | |||
| reflection.through_reflection.klass.find_by(source_foreign_key => @attachment_record.id, | |||
| through_foreign_key => @record.id) | |||
| end | |||
|
|
|||
| def has_many_reflection? | |||
There was a problem hiding this comment.
Noice extracting this method! LGTM!
Paul-Bob
changed the title
reflect_on_association instead _reflectionsreflect_on_association instead _reflections
|
This PR has been merged into Please check the release guide for more information. |
Description
The private
_reflectionsAPI was used to access association reflections in the codebase. This approach relied on internal Rails APIs, which are prone to changes and could lead to compatibility issues in future Rails versions.This PR replaces the use of the private
_reflectionsAPI with the publicreflect_on_associationmethod. This method is part of the officialActiveRecord::Reflection::ClassMethodsand provides a more robust and future-proof way to access association reflections.