Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performance: don't fetch fields on action's initialization #3066

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #3025

Fetch fields on each action request instead of on each action initialization.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Jul 29, 2024
@github-actions github-actions bot added the Fix label Jul 29, 2024
Copy link

codeclimate bot commented Jul 29, 2024

Code Climate has analyzed commit 759ae72 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob removed the Fix label Jul 29, 2024
@Paul-Bob Paul-Bob changed the title fix: don't fetch fields on action's initialization performance: don't fetch fields on action's initialization Jul 29, 2024
Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests for this, please?

@Paul-Bob Paul-Bob merged commit b660e64 into main Jul 29, 2024
22 checks passed
@Paul-Bob Paul-Bob deleted the fix/dont_fetch_fields_when_initializing_actions branch July 29, 2024 14:21
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if we can stop running the fields method on each resource index page load
2 participants