Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write test for warnings #3057

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

binarygit
Copy link
Contributor

@binarygit binarygit commented Jul 25, 2024

Description

This adds tests for #3054

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented Jul 25, 2024

Code Climate has analyzed commit 1204e59 and detected 0 issues on this pull request.

View more on Code Climate.

@binarygit
Copy link
Contributor Author

@Paul-Bob I was just about to push these when the PR got merged. Sorry for the trouble!

spec/features/avo/avo_warning_spec.rb Outdated Show resolved Hide resolved
@Paul-Bob
Copy link
Contributor

Thanks @binarygit

@Paul-Bob Paul-Bob merged commit 3bce3ba into avo-hq:main Jul 25, 2024
8 of 11 checks passed
@Paul-Bob Paul-Bob added the Chore label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants