Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Display warning when menu editor is used in community license #3056

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

binarygit
Copy link
Contributor

@binarygit binarygit commented Jul 25, 2024

Description

Fixes #3054

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

image

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@binarygit binarygit changed the title Display warning when menu editor is used in community license Feature: Display warning when menu editor is used in community license Jul 25, 2024
Copy link

codeclimate bot commented Jul 25, 2024

Code Climate has analyzed commit c4748ea and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @binarygit it's looking good, I just tweaked the message, otherwise, it is good to go.

lib/avo.rb Outdated Show resolved Hide resolved
Co-authored-by: Paul Bob <[email protected]>
lib/avo.rb Outdated Show resolved Hide resolved
lib/avo.rb Outdated Show resolved Hide resolved
@Paul-Bob Paul-Bob merged commit 06a2e51 into avo-hq:main Jul 25, 2024
15 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intercept the main_menu/profile_menu calls and show a warning if the user is on the Community License
2 participants