Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Rails.application.secret_key_base directly #2417

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

segiddins
Copy link

This helps avoid the rails 7.1 deprecation warning about using Rails.application.secrets when no secret key base is explicitly configured, when Rails.env.local? || ENV["SECRET_KEY_BASE_DUMMY"]

Description

Fixes # (issue)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

This helps avoid the rails 7.1 deprecation warning about using `Rails.application.secrets` when no secret key base is explicitly configured, when `Rails.env.local? || ENV["SECRET_KEY_BASE_DUMMY"]`
@adrianthedev
Copy link
Collaborator

It seems that Rails.application.secret_key_base does what we already did in the removed method.
I didn't know that.
Thanks @segiddins!

@adrianthedev adrianthedev merged commit 7cb02f5 into avo-hq:2.x Jan 27, 2024
10 checks passed
@segiddins segiddins deleted the patch-1 branch February 9, 2024 09:03
@jpawlyn
Copy link
Contributor

jpawlyn commented Jul 18, 2024

Would it be ok to have a similar PR against main @adrianthedev to avoid the deprecation warning for Avo 3 ? If so happy to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants