improvement: apply policy scope on has many search query

[Paul-Bob]

Description

Fixes #1808

Scope example

class UserPolicy < ApplicationPolicy

  # . . .

  # . . .

  class Scope < Scope
    def resolve
      scope.where("first_name like ?", "%a%")
    end
  end
end

Before

When searching on a has many field, the policy scope was not being applied, returning all association records.

before.webm

After

Now the policy scope is being applied on the search result.

after.webm

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[codeclimate]

Code Climate has analyzed commit 5dc0d23 and detected 0 issues on this pull request.

View more on Code Climate.

[useattractor]

improvement: apply policy scope on has many search query 🔗

Stats

Language	Score	Trend
Ruby	8.41 (from 8.4)	📈 0.13%
JavaScript	28.35 (from 28.35)	📉 0.0%

Trends

	Most Improved	Largest Declines
Ruby	No decreases for Ruby detected	app/controllers/avo/search_controller.rb
JavaScript	No decreases for JavaScript detected	No increases for JavaScript detected

To-Dos

	New to Refactor	Refactored
Ruby	No new To-Dos for Ruby detected	No completed To-Dos for Ruby detected
JavaScript	No new To-Dos for JavaScript detected	No completed To-Dos for JavaScript detected

[adrianthedev]

Can we also add some tests?

[useattractor]

improvement: apply policy scope on has many search query 🔗

Stats

Language	Score	Trend
Ruby	8.42 (from 8.4)	📈 0.22%
JavaScript	28.35 (from 28.35)	📉 0.0%

Trends

	Most Improved	Largest Declines
Ruby	No decreases for Ruby detected	app/controllers/avo/search_controller.rb
JavaScript	No decreases for JavaScript detected	No increases for JavaScript detected

To-Dos

	New to Refactor	Refactored
Ruby	No new To-Dos for Ruby detected	No completed To-Dos for Ruby detected
JavaScript	No new To-Dos for JavaScript detected	No completed To-Dos for JavaScript detected

[useattractor]

improvement: apply policy scope on has many search query 🔗

Stats

Language	Score	Trend
Ruby	8.43 (from 8.4)	📈 0.36%
JavaScript	28.35 (from 28.35)	📉 0.0%

Trends

	Most Improved	Largest Declines
Ruby	No decreases for Ruby detected	app/controllers/avo/search_controller.rb
JavaScript	No decreases for JavaScript detected	No increases for JavaScript detected

To-Dos

	New to Refactor	Refactored
Ruby	No new To-Dos for Ruby detected	No completed To-Dos for Ruby detected
JavaScript	No new To-Dos for JavaScript detected	No completed To-Dos for JavaScript detected

[useattractor]

improvement: apply policy scope on has many search query 🔗

Stats

Language	Score	Trend
Ruby	8.43 (from 8.4)	📈 0.36%
JavaScript	28.35 (from 28.35)	📉 0.0%

Trends

	Most Improved	Largest Declines
Ruby	No decreases for Ruby detected	app/controllers/avo/search_controller.rb
JavaScript	No decreases for JavaScript detected	No increases for JavaScript detected

To-Dos

	New to Refactor	Refactored
Ruby	No new To-Dos for Ruby detected	No completed To-Dos for Ruby detected
JavaScript	No new To-Dos for JavaScript detected	No completed To-Dos for JavaScript detected

[useattractor]

improvement: apply policy scope on has many search query 🔗

Stats

Language	Score	Trend
Ruby	8.36 (from 8.33)	📈 0.37%
JavaScript	28.35 (from 28.35)	📉 0.0%

Trends

	Most Improved	Largest Declines
Ruby	No decreases for Ruby detected	app/controllers/avo/search_controller.rb
JavaScript	No decreases for JavaScript detected	No increases for JavaScript detected

To-Dos

	New to Refactor	Refactored
Ruby	No new To-Dos for Ruby detected	No completed To-Dos for Ruby detected
JavaScript	No new To-Dos for JavaScript detected	No completed To-Dos for JavaScript detected

[github-actions]

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.