Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide tags field on community license #1806

Merged
merged 4 commits into from
Jun 28, 2023

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jun 28, 2023

Description

Fixes #1805

The "Tags" field is a feature available in the Pro license, but for some reason, it was visible even on the community license. However, the field was not being updated properly. This created a misleading impression that there was a problem with the field.

Now tags field is hidden on community license.

Seeds was commented not sure why, this PR also uncomment seeds

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

@Paul-Bob Paul-Bob self-assigned this Jun 28, 2023
@github-actions github-actions bot added the Fix label Jun 28, 2023
@codeclimate
Copy link

codeclimate bot commented Jun 28, 2023

Code Climate has analyzed commit ea3df9f and detected 0 issues on this pull request.

View more on Code Climate.

@useattractor
Copy link

useattractor bot commented Jun 28, 2023

fix: hide tags field on community license 🔗

Stats

Language Score Trend
Ruby 8.33 (from 8.32) 📈 0.05%
JavaScript 28.35 (from 28.35) 📉 0.0%

Trends

Most Improved Largest Declines
Ruby No decreases for Ruby detected lib/avo/fields/tags_field.rb
JavaScript No decreases for JavaScript detected No increases for JavaScript detected

To-Dos

New to Refactor Refactored
Ruby No new To-Dos for Ruby detected No completed To-Dos for Ruby detected
JavaScript No new To-Dos for JavaScript detected No completed To-Dos for JavaScript detected

@useattractor
Copy link

useattractor bot commented Jun 28, 2023

fix: hide tags field on community license 🔗

Stats

Language Score Trend
Ruby 8.34 (from 8.32) 📈 0.22%
JavaScript 28.35 (from 28.35) 📉 0.0%

Trends

Most Improved Largest Declines
Ruby lib/avo/concerns/has_fields.rb lib/avo/items_holder.rb
JavaScript No decreases for JavaScript detected No increases for JavaScript detected

To-Dos

New to Refactor Refactored
Ruby No new To-Dos for Ruby detected No completed To-Dos for Ruby detected
JavaScript No new To-Dos for JavaScript detected No completed To-Dos for JavaScript detected

@useattractor
Copy link

useattractor bot commented Jun 28, 2023

fix: hide tags field on community license 🔗

Stats

Language Score Trend
Ruby 8.34 (from 8.32) 📈 0.25%
JavaScript 28.35 (from 28.35) 📉 0.0%

Trends

Most Improved Largest Declines
Ruby lib/avo/concerns/has_fields.rb lib/avo/items_holder.rb
JavaScript No decreases for JavaScript detected No increases for JavaScript detected

To-Dos

New to Refactor Refactored
Ruby No new To-Dos for Ruby detected No completed To-Dos for Ruby detected
JavaScript No new To-Dos for JavaScript detected No completed To-Dos for JavaScript detected

@useattractor
Copy link

useattractor bot commented Jun 28, 2023

fix: hide tags field on community license 🔗

Stats

Language Score Trend
Ruby 8.35 (from 8.32) 📈 0.27%
JavaScript 28.35 (from 28.35) 📉 0.0%

Trends

Most Improved Largest Declines
Ruby lib/avo/concerns/has_fields.rb lib/avo/items_holder.rb
JavaScript No decreases for JavaScript detected No increases for JavaScript detected

To-Dos

New to Refactor Refactored
Ruby No new To-Dos for Ruby detected No completed To-Dos for Ruby detected
JavaScript No new To-Dos for JavaScript detected No completed To-Dos for JavaScript detected

@adrianthedev adrianthedev merged commit a45a460 into main Jun 28, 2023
@adrianthedev adrianthedev deleted the fix/tags_field_community_license branch June 28, 2023 16:42
@github-actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide the tags field on production if the user doesn't have the proper license
2 participants