Refactor - better error handling when no city or no timezone found

avo-hq · Nov 18, 2023 · 9863626 · 9863626
1 parent ba0165c
commit 9863626
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/spec/dummy/app/avo/actions/show_current_time.rb b/spec/dummy/app/avo/actions/show_current_time.rb
@@ -24,9 +24,9 @@ class ShowCurrentTime < Avo::BaseAction
 
   def handle(**args)
     city = args.dig(:fields, :city)
+    timezone_id = Course.timezones.find { |_, cities| cities.include?(city) }&.first
 
-    if city
-      timezone_id = Course.timezones.find { |_, cities| cities.include?(city) }.first
+    if timezone_id
       formatted_current_time = TZInfo::Timezone.get(timezone_id).now.strftime('%H:%M:%S')
 
       succeed "In #{city} it's now #{formatted_current_time}."