This repository has been archived by the owner on Aug 7, 2018. It is now read-only.
add sql server driver for linux to drivers tested when setting driver_needs_utf8 #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft has a SQL Server driver for linux (http://www.microsoft.com/en-us/download/details.aspx?id=28160)
Sending utf-8 to this driver will corrupt data. It needs parameters to be sent to pyodbc in unicode strings, like other SQL server drivers.
I'm not really advocating accepting this patch, it just demonstrates the smallest possible code change that fixes the issue. I'm not sure if it makes sense to do something like this, to make the list of microsoft drivers configurable, or to directly make the driver_needs_utf8 value configurable.
The full driver name includes a version string, hence the current awkward way the condition is written. if you want to stick with fixing it here, probably looks nicer as something like: