Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserializing AppsResponse #162

Merged
merged 7 commits into from
Aug 17, 2024
Merged

Fix deserializing AppsResponse #162

merged 7 commits into from
Aug 17, 2024

Conversation

trejjam
Copy link
Member

@trejjam trejjam commented Aug 17, 2024

The https://developer.apple.com/documentation/appstoreconnectapi/list_apps returns in the AppsResponse.included polymorphic items. The issue is that it returns https://developer.apple.com/documentation/appstoreconnectapi/inapppurchasev2 and https://developer.apple.com/documentation/appstoreconnectapi/inapppurchase, which contains the same discriminator key.

To resolve this, we removed the InAppPurchase from possible values.

@trejjam trejjam changed the title Add test deserializing AppsResponse Fix deserializing AppsResponse Aug 17, 2024
@trejjam trejjam added this pull request to the merge queue Aug 17, 2024
Merged via the queue into main with commit e4103b3 Aug 17, 2024
2 checks passed
@trejjam trejjam deleted the feature/typo branch August 17, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant