OptAnalyzer: fix #643, ignore reports from callee on `throw` path #645

aviatesk · 2024-07-03T06:28:18Z

In the analysis performed by OptAnalyzer, when the skip_unoptimized_throw_blocks configuration is enabled, dynamic dispatch on throw code path is supposed to be ignored. However, cached reports of non-inlined callees on the throw code path were not ignored, leading to confusion (#643). This commit addresses the issue by overloading the propagation of reports from callees in abstract interpretation.

While the issue has been resolved, the resulting code is quite hacky, and improvements to these interfaces are certainly desirable.

github-actions · 2024-07-03T06:50:26Z

JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

Time of benchmarks:

Target: 3 Jul 2024 - 06:39
Baseline: 3 Jul 2024 - 06:50

Package commits:

Target: 511318
Baseline: cb2c46

Julia commits:

Target: 48d4fd
Baseline: 48d4fd

Julia command flags:

Target: None
Baseline: None

Environment variables:

Target: None
Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"]`	1.06 (5%) ❌	1.00 (1%)
`["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"]`	1.06 (5%) ❌	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["First-Time-To-JET"]
["JETAnalyzer{BasicPass} top-level"]
["JETAnalyzer{BasicPass}"]
["JETAnalyzer{SoundPass}"]
["OptAnalyzer"]
["show(::IO, ::JETCallResult)"]

Julia versioninfo

Target

Julia Version 1.10.4
Commit 48d4fd48430 (2024-06-04 10:41 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.4 LTS
 uname: Linux 6.5.0-1022-azure #23~22.04.1-Ubuntu SMP Thu May 9 17:59:24 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3244 MHz 2058 s 0 s 165 s 6096 s 0 s
 #2 2445 MHz 1857 s 0 s 175 s 6276 s 0 s
 #3 2592 MHz 2220 s 0 s 184 s 5910 s 0 s
 #4 3221 MHz 1885 s 0 s 174 s 6256 s 0 s
 Memory: 15.606487274169922 GB (12262.88671875 MB free)
 Uptime: 835.12 sec
 Load Avg: 1.08 1.03 0.66
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline

Julia Version 1.10.4
Commit 48d4fd48430 (2024-06-04 10:41 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.4 LTS
 uname: Linux 6.5.0-1022-azure #23~22.04.1-Ubuntu SMP Thu May 9 17:59:24 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 2445 MHz 3983 s 0 s 293 s 10139 s 0 s
 #2 2445 MHz 4019 s 0 s 291 s 10096 s 0 s
 #3 3274 MHz 3415 s 0 s 310 s 10686 s 0 s
 #4 3242 MHz 3498 s 0 s 299 s 10616 s 0 s
 Memory: 15.606487274169922 GB (11731.08984375 MB free)
 Uptime: 1445.94 sec
 Load Avg: 1.13 1.11 0.93
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

Time of benchmark: 3 Jul 2024 - 6:39
Package commit: 511318
Julia commit: 48d4fd
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["First-Time-To-JET", "package loading"]`	181.894 ms (5%)		64.67 KiB (1%)	17
`["First-Time-To-JET", "rand(Bool)"]`	500.689 ms (5%)		65.08 KiB (1%)	17
`["First-Time-To-JET", "sum(\"julia\")"]`	251.198 ms (5%)		65.08 KiB (1%)	17
`["JETAnalyzer{BasicPass} top-level", "demo"]`	32.947 ms (5%)		2.11 MiB (1%)	36419
`["JETAnalyzer{BasicPass} top-level", "self analysis"]`	9.770 s (5%)	473.676 ms	1.49 GiB (1%)	28004815
`["JETAnalyzer{BasicPass} top-level", "simple"]`	7.936 ms (5%)		2.02 MiB (1%)	35468
`["JETAnalyzer{BasicPass}", "identity(nothing)"]`	80.840 μs (5%)		7.94 KiB (1%)	113
`["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"]`	135.705 ms (5%)		43.18 MiB (1%)	810500
`["JETAnalyzer{BasicPass}", "rand(Bool)"]`	38.610 ms (5%)		14.53 MiB (1%)	267056
`["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"]`	136.153 μs (5%)		16.05 KiB (1%)	227
`["JETAnalyzer{BasicPass}", "sum(\"julia\")"]`	5.184 ms (5%)		1.86 MiB (1%)	33177
`["JETAnalyzer{SoundPass}", "identity(nothing)"]`	84.287 μs (5%)		7.94 KiB (1%)	113
`["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"]`	161.971 ms (5%)		73.69 MiB (1%)	947646
`["JETAnalyzer{SoundPass}", "rand(Bool)"]`	40.772 ms (5%)		16.34 MiB (1%)	283520
`["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"]`	137.816 μs (5%)		19.67 KiB (1%)	252
`["JETAnalyzer{SoundPass}", "sum(\"julia\")"]`	5.393 ms (5%)		1.95 MiB (1%)	34388
`["OptAnalyzer", "identity(nothing)"]`	120.635 μs (5%)		25.39 KiB (1%)	362
`["OptAnalyzer", "println(QuoteNode(nothing))"]`	422.162 ms (5%)		235.79 MiB (1%)	3469831
`["OptAnalyzer", "rand(Bool)"]`	21.731 ms (5%)		14.19 MiB (1%)	210676
`["OptAnalyzer", "sum(\"julia\") (cached)"]`	217.264 μs (5%)		56.80 KiB (1%)	774
`["OptAnalyzer", "sum(\"julia\")"]`	10.959 ms (5%)		6.48 MiB (1%)	96839
`["show(::IO, ::JETCallResult)", "report_call"]`	4.543 ms (5%)		1.33 MiB (1%)	18166
`["show(::IO, ::JETCallResult)", "report_opt"]`	233.589 ms (5%)		73.85 MiB (1%)	1141214

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["First-Time-To-JET"]
["JETAnalyzer{BasicPass} top-level"]
["JETAnalyzer{BasicPass}"]
["JETAnalyzer{SoundPass}"]
["OptAnalyzer"]
["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.4
Commit 48d4fd48430 (2024-06-04 10:41 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.4 LTS
 uname: Linux 6.5.0-1022-azure #23~22.04.1-Ubuntu SMP Thu May 9 17:59:24 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3244 MHz 2058 s 0 s 165 s 6096 s 0 s
 #2 2445 MHz 1857 s 0 s 175 s 6276 s 0 s
 #3 2592 MHz 2220 s 0 s 184 s 5910 s 0 s
 #4 3221 MHz 1885 s 0 s 174 s 6256 s 0 s
 Memory: 15.606487274169922 GB (12262.88671875 MB free)
 Uptime: 835.12 sec
 Load Avg: 1.08 1.03 0.66
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

Time of benchmark: 3 Jul 2024 - 6:50
Package commit: cb2c46
Julia commit: 48d4fd
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	memory	allocations
`["First-Time-To-JET", "package loading"]`	174.991 ms (5%)	64.67 KiB (1%)	17
`["First-Time-To-JET", "rand(Bool)"]`	496.744 ms (5%)	65.08 KiB (1%)	17
`["First-Time-To-JET", "sum(\"julia\")"]`	251.985 ms (5%)	65.08 KiB (1%)	17
`["JETAnalyzer{BasicPass} top-level", "demo"]`	32.008 ms (5%)	2.11 MiB (1%)	36419
`["JETAnalyzer{BasicPass} top-level", "self analysis"]`	9.434 s (5%)	1.49 GiB (1%)	28014542
`["JETAnalyzer{BasicPass} top-level", "simple"]`	7.773 ms (5%)	2.02 MiB (1%)	35468
`["JETAnalyzer{BasicPass}", "identity(nothing)"]`	82.624 μs (5%)	7.94 KiB (1%)	113
`["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"]`	127.934 ms (5%)	43.18 MiB (1%)	810499
`["JETAnalyzer{BasicPass}", "rand(Bool)"]`	38.372 ms (5%)	14.53 MiB (1%)	267055
`["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"]`	128.548 μs (5%)	16.05 KiB (1%)	227
`["JETAnalyzer{BasicPass}", "sum(\"julia\")"]`	5.162 ms (5%)	1.88 MiB (1%)	33178
`["JETAnalyzer{SoundPass}", "identity(nothing)"]`	83.416 μs (5%)	7.94 KiB (1%)	113
`["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"]`	161.329 ms (5%)	74.40 MiB (1%)	947733
`["JETAnalyzer{SoundPass}", "rand(Bool)"]`	41.132 ms (5%)	16.34 MiB (1%)	283519
`["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"]`	133.378 μs (5%)	19.67 KiB (1%)	252
`["JETAnalyzer{SoundPass}", "sum(\"julia\")"]`	5.403 ms (5%)	1.95 MiB (1%)	34388
`["OptAnalyzer", "identity(nothing)"]`	123.059 μs (5%)	25.39 KiB (1%)	362
`["OptAnalyzer", "println(QuoteNode(nothing))"]`	420.299 ms (5%)	235.82 MiB (1%)	3469936
`["OptAnalyzer", "rand(Bool)"]`	21.727 ms (5%)	14.19 MiB (1%)	210675
`["OptAnalyzer", "sum(\"julia\") (cached)"]`	220.771 μs (5%)	56.80 KiB (1%)	774
`["OptAnalyzer", "sum(\"julia\")"]`	10.929 ms (5%)	6.48 MiB (1%)	96839
`["show(::IO, ::JETCallResult)", "report_call"]`	4.592 ms (5%)	1.33 MiB (1%)	18166
`["show(::IO, ::JETCallResult)", "report_opt"]`	237.091 ms (5%)	74.12 MiB (1%)	1146008

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["First-Time-To-JET"]
["JETAnalyzer{BasicPass} top-level"]
["JETAnalyzer{BasicPass}"]
["JETAnalyzer{SoundPass}"]
["OptAnalyzer"]
["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.4
Commit 48d4fd48430 (2024-06-04 10:41 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.4 LTS
 uname: Linux 6.5.0-1022-azure #23~22.04.1-Ubuntu SMP Thu May 9 17:59:24 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 2445 MHz 3983 s 0 s 293 s 10139 s 0 s
 #2 2445 MHz 4019 s 0 s 291 s 10096 s 0 s
 #3 3274 MHz 3415 s 0 s 310 s 10686 s 0 s
 #4 3242 MHz 3498 s 0 s 299 s 10616 s 0 s
 Memory: 15.606487274169922 GB (11731.08984375 MB free)
 Uptime: 1445.94 sec
 Load Avg: 1.13 1.11 0.93
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Runtime information

Runtime Info
BLAS #threads	2
`BLAS.vendor()`	`lbt`
`Sys.CPU_THREADS`	4

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 48 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 4
On-line CPU(s) list: 0-3
Vendor ID: AuthenticAMD
Model name: AMD EPYC 7763 64-Core Processor
CPU family: 25
Model: 1
Thread(s) per core: 2
Core(s) per socket: 2
Socket(s): 1
Stepping: 1
BogoMIPS: 4890.85
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization: AMD-V
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 1 MiB (2 instances)
L3 cache: 32 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Vulnerable: Safe RET, no microcode
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines; STIBP disabled; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected

Cpu Property	Value
Brand	AMD EPYC 7763 64-Core Processor
Vendor	:AMD
Architecture	:Unknown
Model	Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores	16 physical cores, 16 logical cores (on executing CPU)
	No Hyperthreading hardware capability detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 512, 32768) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 48 bits physical
SIMD	256 bit = 32 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via `rdtsc`
	TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

Time of benchmarks:

Target: 3 Jul 2024 - 07:08
Baseline: 3 Jul 2024 - 07:18

Package commits:

Target: 217dbd
Baseline: 447c7a

Julia commits:

Target: 48d4fd
Baseline: 48d4fd

Julia command flags:

Target: None
Baseline: None

Environment variables:

Target: None
Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
`["JETAnalyzer{SoundPass}", "identity(nothing)"]`	0.94 (5%) ✅	1.00 (1%)
`["OptAnalyzer", "identity(nothing)"]`	1.05 (5%) ❌	1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["First-Time-To-JET"]
["JETAnalyzer{BasicPass} top-level"]
["JETAnalyzer{BasicPass}"]
["JETAnalyzer{SoundPass}"]
["OptAnalyzer"]
["show(::IO, ::JETCallResult)"]

Julia versioninfo

Target

Julia Version 1.10.4
Commit 48d4fd48430 (2024-06-04 10:41 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.4 LTS
 uname: Linux 6.5.0-1022-azure #23~22.04.1-Ubuntu SMP Thu May 9 17:59:24 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3059 MHz 2724 s 0 s 183 s 5897 s 0 s
 #2 2445 MHz 2904 s 0 s 145 s 5750 s 0 s
 #3 3243 MHz 1296 s 0 s 190 s 7315 s 0 s
 #4 3273 MHz 1143 s 0 s 190 s 7470 s 0 s
 Memory: 15.606491088867188 GB (12239.9375 MB free)
 Uptime: 883.74 sec
 Load Avg: 1.0 1.03 0.68
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline

Julia Version 1.10.4
Commit 48d4fd48430 (2024-06-04 10:41 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.4 LTS
 uname: Linux 6.5.0-1022-azure #23~22.04.1-Ubuntu SMP Thu May 9 17:59:24 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3247 MHz 4054 s 0 s 326 s 10048 s 0 s
 #2 3244 MHz 3977 s 0 s 301 s 10148 s 0 s
 #3 2445 MHz 2932 s 0 s 348 s 11149 s 0 s
 #4 2889 MHz 2990 s 0 s 363 s 11079 s 0 s
 Memory: 15.606491088867188 GB (12234.40625 MB free)
 Uptime: 1447.3 sec
 Load Avg: 1.07 1.08 0.91
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

Time of benchmark: 3 Jul 2024 - 7:8
Package commit: 217dbd
Julia commit: 48d4fd
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["First-Time-To-JET", "package loading"]`	186.443 ms (5%)		64.67 KiB (1%)	17
`["First-Time-To-JET", "rand(Bool)"]`	554.902 ms (5%)		65.08 KiB (1%)	17
`["First-Time-To-JET", "sum(\"julia\")"]`	253.745 ms (5%)		65.08 KiB (1%)	17
`["JETAnalyzer{BasicPass} top-level", "demo"]`	33.135 ms (5%)		2.11 MiB (1%)	36419
`["JETAnalyzer{BasicPass} top-level", "self analysis"]`	10.302 s (5%)	512.077 ms	1.49 GiB (1%)	28004816
`["JETAnalyzer{BasicPass} top-level", "simple"]`	8.007 ms (5%)		2.02 MiB (1%)	35468
`["JETAnalyzer{BasicPass}", "identity(nothing)"]`	84.317 μs (5%)		7.94 KiB (1%)	113
`["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"]`	131.464 ms (5%)		43.18 MiB (1%)	810498
`["JETAnalyzer{BasicPass}", "rand(Bool)"]`	38.847 ms (5%)		14.53 MiB (1%)	267054
`["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"]`	128.730 μs (5%)		16.05 KiB (1%)	227
`["JETAnalyzer{BasicPass}", "sum(\"julia\")"]`	5.206 ms (5%)		1.88 MiB (1%)	33178
`["JETAnalyzer{SoundPass}", "identity(nothing)"]`	81.683 μs (5%)		7.94 KiB (1%)	113
`["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"]`	164.084 ms (5%)		74.36 MiB (1%)	947725
`["JETAnalyzer{SoundPass}", "rand(Bool)"]`	41.178 ms (5%)		16.34 MiB (1%)	283518
`["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"]`	143.187 μs (5%)		19.67 KiB (1%)	252
`["JETAnalyzer{SoundPass}", "sum(\"julia\")"]`	5.337 ms (5%)		1.95 MiB (1%)	34388
`["OptAnalyzer", "identity(nothing)"]`	129.932 μs (5%)		25.39 KiB (1%)	362
`["OptAnalyzer", "println(QuoteNode(nothing))"]`	425.856 ms (5%)		235.79 MiB (1%)	3469833
`["OptAnalyzer", "rand(Bool)"]`	21.858 ms (5%)		14.19 MiB (1%)	210674
`["OptAnalyzer", "sum(\"julia\") (cached)"]`	215.251 μs (5%)		56.80 KiB (1%)	774
`["OptAnalyzer", "sum(\"julia\")"]`	10.861 ms (5%)		6.48 MiB (1%)	96839
`["show(::IO, ::JETCallResult)", "report_call"]`	4.591 ms (5%)		1.33 MiB (1%)	18166
`["show(::IO, ::JETCallResult)", "report_opt"]`	233.503 ms (5%)		73.85 MiB (1%)	1141214

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["First-Time-To-JET"]
["JETAnalyzer{BasicPass} top-level"]
["JETAnalyzer{BasicPass}"]
["JETAnalyzer{SoundPass}"]
["OptAnalyzer"]
["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.4
Commit 48d4fd48430 (2024-06-04 10:41 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.4 LTS
 uname: Linux 6.5.0-1022-azure #23~22.04.1-Ubuntu SMP Thu May 9 17:59:24 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3059 MHz 2724 s 0 s 183 s 5897 s 0 s
 #2 2445 MHz 2904 s 0 s 145 s 5750 s 0 s
 #3 3243 MHz 1296 s 0 s 190 s 7315 s 0 s
 #4 3273 MHz 1143 s 0 s 190 s 7470 s 0 s
 Memory: 15.606491088867188 GB (12239.9375 MB free)
 Uptime: 883.74 sec
 Load Avg: 1.0 1.03 0.68
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

Time of benchmark: 3 Jul 2024 - 7:18
Package commit: 447c7a
Julia commit: 48d4fd
Julia command flags: None
Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID	time	GC time	memory	allocations
`["First-Time-To-JET", "package loading"]`	181.943 ms (5%)		64.67 KiB (1%)	17
`["First-Time-To-JET", "rand(Bool)"]`	557.925 ms (5%)		65.08 KiB (1%)	17
`["First-Time-To-JET", "sum(\"julia\")"]`	254.695 ms (5%)		65.08 KiB (1%)	17
`["JETAnalyzer{BasicPass} top-level", "demo"]`	32.244 ms (5%)		2.11 MiB (1%)	36419
`["JETAnalyzer{BasicPass} top-level", "self analysis"]`	10.239 s (5%)	501.415 ms	1.49 GiB (1%)	28004816
`["JETAnalyzer{BasicPass} top-level", "simple"]`	7.890 ms (5%)		2.01 MiB (1%)	35468
`["JETAnalyzer{BasicPass}", "identity(nothing)"]`	86.701 μs (5%)		7.94 KiB (1%)	113
`["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"]`	129.991 ms (5%)		43.18 MiB (1%)	810498
`["JETAnalyzer{BasicPass}", "rand(Bool)"]`	39.063 ms (5%)		14.53 MiB (1%)	267054
`["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"]`	134.321 μs (5%)		16.05 KiB (1%)	227
`["JETAnalyzer{BasicPass}", "sum(\"julia\")"]`	5.385 ms (5%)		1.88 MiB (1%)	33178
`["JETAnalyzer{SoundPass}", "identity(nothing)"]`	87.122 μs (5%)		7.94 KiB (1%)	113
`["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"]`	163.685 ms (5%)		74.36 MiB (1%)	947725
`["JETAnalyzer{SoundPass}", "rand(Bool)"]`	40.749 ms (5%)		16.34 MiB (1%)	283518
`["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"]`	140.773 μs (5%)		19.67 KiB (1%)	252
`["JETAnalyzer{SoundPass}", "sum(\"julia\")"]`	5.225 ms (5%)		1.95 MiB (1%)	34388
`["OptAnalyzer", "identity(nothing)"]`	123.590 μs (5%)		25.39 KiB (1%)	362
`["OptAnalyzer", "println(QuoteNode(nothing))"]`	423.492 ms (5%)		235.79 MiB (1%)	3469833
`["OptAnalyzer", "rand(Bool)"]`	21.791 ms (5%)		14.19 MiB (1%)	210674
`["OptAnalyzer", "sum(\"julia\") (cached)"]`	220.171 μs (5%)		56.80 KiB (1%)	774
`["OptAnalyzer", "sum(\"julia\")"]`	10.921 ms (5%)		6.48 MiB (1%)	96839
`["show(::IO, ::JETCallResult)", "report_call"]`	4.677 ms (5%)		1.33 MiB (1%)	18166
`["show(::IO, ::JETCallResult)", "report_opt"]`	240.419 ms (5%)		73.85 MiB (1%)	1141214

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

["First-Time-To-JET"]
["JETAnalyzer{BasicPass} top-level"]
["JETAnalyzer{BasicPass}"]
["JETAnalyzer{SoundPass}"]
["OptAnalyzer"]
["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.10.4
Commit 48d4fd48430 (2024-06-04 10:41 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.4 LTS
 uname: Linux 6.5.0-1022-azure #23~22.04.1-Ubuntu SMP Thu May 9 17:59:24 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3247 MHz 4054 s 0 s 326 s 10048 s 0 s
 #2 3244 MHz 3977 s 0 s 301 s 10148 s 0 s
 #3 2445 MHz 2932 s 0 s 348 s 11149 s 0 s
 #4 2889 MHz 2990 s 0 s 363 s 11079 s 0 s
 Memory: 15.606491088867188 GB (12234.40625 MB free)
 Uptime: 1447.3 sec
 Load Avg: 1.07 1.08 0.91
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Runtime information

Runtime Info
BLAS #threads	2
`BLAS.vendor()`	`lbt`
`Sys.CPU_THREADS`	4

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 48 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 4
On-line CPU(s) list: 0-3
Vendor ID: AuthenticAMD
Model name: AMD EPYC 7763 64-Core Processor
CPU family: 25
Model: 1
Thread(s) per core: 2
Core(s) per socket: 2
Socket(s): 1
Stepping: 1
BogoMIPS: 4890.86
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization: AMD-V
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 1 MiB (2 instances)
L3 cache: 32 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Vulnerable: Safe RET, no microcode
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines; STIBP disabled; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected

Cpu Property	Value
Brand	AMD EPYC 7763 64-Core Processor
Vendor	:AMD
Architecture	:Unknown
Model	Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores	16 physical cores, 16 logical cores (on executing CPU)
	No Hyperthreading hardware capability detected
Clock Frequencies	Not supported by CPU
Data Cache	Level 1:3 : (32, 512, 32768) kbytes
	64 byte cache line size
Address Size	48 bits virtual, 48 bits physical
SIMD	256 bit = 32 byte max. SIMD vector size
Time Stamp Counter	TSC is accessible via `rdtsc`
	TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring	Performance Monitoring Counters (PMC) are not supported
Hypervisor	Yes, Microsoft

In the analysis performed by `OptAnalyzer`, when the `skip_unoptimized_throw_blocks` configuration is enabled, dynamic dispatch on `throw` code path is supposed to be ignored. However, cached reports of non-inlined callees on the `throw` code path were not ignored, leading to confusion (#643). This commit addresses the issue by overloading the propagation of reports from callees in abstract interpretation. While the issue has been resolved, the resulting code is quite hacky, and improvements to these interfaces are certainly desirable.

aviatesk force-pushed the avi/fix-643 branch from 643113b to 5a054e6 Compare July 3, 2024 06:57

aviatesk merged commit 447c7a3 into master Jul 3, 2024
9 of 10 checks passed

aviatesk deleted the avi/fix-643 branch July 3, 2024 07:01

OptAnalyzer: fix #643, ignore reports from callee on throw path #645

OptAnalyzer: fix #643, ignore reports from callee on throw path #645

Conversation

aviatesk commented Jul 3, 2024

github-actions bot commented Jul 3, 2024 • edited Loading

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Runtime information

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Target

Baseline

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

Results

Benchmark Group List

Julia versioninfo

Runtime information

OptAnalyzer: fix #643, ignore reports from callee on `throw` path #645

OptAnalyzer: fix #643, ignore reports from callee on `throw` path #645

github-actions bot commented Jul 3, 2024 •

edited

Loading