Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #581, report dangerous indexing #582

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix #581, report dangerous indexing #582

merged 1 commit into from
Dec 12, 2023

Conversation

aviatesk
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aec0e21) 89.34% compared to head (edcebbe) 89.35%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
+ Coverage   89.34%   89.35%   +0.01%     
==========================================
  Files          10       10              
  Lines        3087     3092       +5     
==========================================
+ Hits         2758     2763       +5     
  Misses        329      329

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

JET Benchmark Result

Judge result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmarks:
  • Target: 12 Dec 2023 - 08:46
  • Baseline: 12 Dec 2023 - 08:56
  • Package commits:
  • Target: 2960c7
  • Baseline: aec0e2
  • Julia commits:
  • Target: e39e77
  • Baseline: e39e77
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["JETAnalyzer{BasicPass} top-level", "simple"] 0.92 (5%) ✅ 1.00 (1%)
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 1.05 (5%) ❌ 1.00 (1%)
["show(::IO, ::JETCallResult)", "report_call"] 0.94 (5%) ✅ 1.00 (1%)
["show(::IO, ::JETCallResult)", "report_opt"] 0.74 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Target

Julia Version 1.11.0-DEV.1079
Commit e39e77fa9eb (2023-12-11 23:12 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3254 MHz 2543 s 0 s 172 s 5596 s 0 s
 #2 3243 MHz 1853 s 0 s 172 s 6287 s 0 s
 #3 2445 MHz 2109 s 0 s 182 s 6019 s 0 s
 #4 2577 MHz 1599 s 0 s 162 s 6543 s 0 s
 Memory: 15.60690689086914 GB (11486.953125 MB free)
 Uptime: 834.53 sec
 Load Avg: 1.06 1.02 0.65
 WORD_SIZE: 64
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
 Threads: 1 on 4 virtual cores

Baseline

Julia Version 1.11.0-DEV.1079
Commit e39e77fa9eb (2023-12-11 23:12 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 2445 MHz 4338 s 0 s 285 s 10038 s 0 s
 #2 2445 MHz 3189 s 0 s 294 s 11179 s 0 s
 #3 3242 MHz 3768 s 0 s 312 s 10583 s 0 s
 #4 3258 MHz 3617 s 0 s 287 s 10754 s 0 s
 Memory: 15.60690689086914 GB (11240.76953125 MB free)
 Uptime: 1470.91 sec
 Load Avg: 1.08 1.08 0.92
 WORD_SIZE: 64
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
 Threads: 1 on 4 virtual cores

Target result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 12 Dec 2023 - 8:46
  • Package commit: 2960c7
  • Julia commit: e39e77
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 806.097 ms (5%) 64.85 KiB (1%) 24
["First-Time-To-JET", "rand(Bool)"] 603.312 ms (5%) 65.26 KiB (1%) 24
["First-Time-To-JET", "sum(\"julia\")"] 221.283 ms (5%) 65.26 KiB (1%) 24
["JETAnalyzer{BasicPass} top-level", "demo"] 34.161 ms (5%) 2.09 MiB (1%) 43005
["JETAnalyzer{BasicPass} top-level", "self analysis"] 7.178 s (5%) 313.551 ms 1.58 GiB (1%) 34940599
["JETAnalyzer{BasicPass} top-level", "simple"] 8.989 ms (5%) 2.02 MiB (1%) 46316
["JETAnalyzer{BasicPass}", "identity(nothing)"] 89.758 μs (5%) 7.55 KiB (1%) 145
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 106.494 ms (5%) 37.42 MiB (1%) 880333
["JETAnalyzer{BasicPass}", "rand(Bool)"] 50.229 ms (5%) 17.07 MiB (1%) 398664
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 128.101 μs (5%) 15.05 KiB (1%) 257
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 5.687 ms (5%) 1.86 MiB (1%) 43306
["JETAnalyzer{SoundPass}", "identity(nothing)"] 90.620 μs (5%) 7.55 KiB (1%) 145
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 129.270 ms (5%) 51.11 MiB (1%) 979133
["JETAnalyzer{SoundPass}", "rand(Bool)"] 54.483 ms (5%) 19.15 MiB (1%) 420923
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 150.302 μs (5%) 17.67 KiB (1%) 290
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 6.606 ms (5%) 1.92 MiB (1%) 44458
["OptAnalyzer", "identity(nothing)"] 72.737 μs (5%) 6.06 KiB (1%) 132
["OptAnalyzer", "println(QuoteNode(nothing))"] 392.740 ms (5%) 244.35 MiB (1%) 4563392
["OptAnalyzer", "rand(Bool)"] 26.252 ms (5%) 16.52 MiB (1%) 331468
["OptAnalyzer", "sum(\"julia\") (cached)"] 207.931 μs (5%) 61.38 KiB (1%) 990
["OptAnalyzer", "sum(\"julia\")"] 11.762 ms (5%) 7.68 MiB (1%) 151221
["show(::IO, ::JETCallResult)", "report_call"] 3.536 ms (5%) 1.14 MiB (1%) 9485
["show(::IO, ::JETCallResult)", "report_opt"] 11.602 μs (5%) 728 bytes (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.11.0-DEV.1079
Commit e39e77fa9eb (2023-12-11 23:12 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3254 MHz 2543 s 0 s 172 s 5596 s 0 s
 #2 3243 MHz 1853 s 0 s 172 s 6287 s 0 s
 #3 2445 MHz 2109 s 0 s 182 s 6019 s 0 s
 #4 2577 MHz 1599 s 0 s 162 s 6543 s 0 s
 Memory: 15.60690689086914 GB (11486.953125 MB free)
 Uptime: 834.53 sec
 Load Avg: 1.06 1.02 0.65
 WORD_SIZE: 64
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
 Threads: 1 on 4 virtual cores

Baseline result

Benchmark Report for /home/runner/work/JET.jl/JET.jl

Job Properties

  • Time of benchmark: 12 Dec 2023 - 8:56
  • Package commit: aec0e2
  • Julia commit: e39e77
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["First-Time-To-JET", "package loading"] 817.360 ms (5%) 64.85 KiB (1%) 24
["First-Time-To-JET", "rand(Bool)"] 616.832 ms (5%) 65.26 KiB (1%) 24
["First-Time-To-JET", "sum(\"julia\")"] 220.373 ms (5%) 65.26 KiB (1%) 24
["JETAnalyzer{BasicPass} top-level", "demo"] 33.568 ms (5%) 2.09 MiB (1%) 42995
["JETAnalyzer{BasicPass} top-level", "self analysis"] 7.281 s (5%) 298.446 ms 1.58 GiB (1%) 34940595
["JETAnalyzer{BasicPass} top-level", "simple"] 9.782 ms (5%) 2.02 MiB (1%) 46316
["JETAnalyzer{BasicPass}", "identity(nothing)"] 90.691 μs (5%) 7.55 KiB (1%) 145
["JETAnalyzer{BasicPass}", "println(QuoteNode(nothing))"] 106.511 ms (5%) 37.42 MiB (1%) 880329
["JETAnalyzer{BasicPass}", "rand(Bool)"] 48.637 ms (5%) 17.07 MiB (1%) 398660
["JETAnalyzer{BasicPass}", "sum(\"julia\") (cached)"] 131.537 μs (5%) 15.05 KiB (1%) 257
["JETAnalyzer{BasicPass}", "sum(\"julia\")"] 5.927 ms (5%) 1.86 MiB (1%) 43306
["JETAnalyzer{SoundPass}", "identity(nothing)"] 93.095 μs (5%) 7.55 KiB (1%) 145
["JETAnalyzer{SoundPass}", "println(QuoteNode(nothing))"] 130.980 ms (5%) 51.11 MiB (1%) 979129
["JETAnalyzer{SoundPass}", "rand(Bool)"] 54.855 ms (5%) 19.15 MiB (1%) 420919
["JETAnalyzer{SoundPass}", "sum(\"julia\") (cached)"] 142.468 μs (5%) 17.67 KiB (1%) 290
["JETAnalyzer{SoundPass}", "sum(\"julia\")"] 6.726 ms (5%) 1.92 MiB (1%) 44458
["OptAnalyzer", "identity(nothing)"] 76.514 μs (5%) 6.06 KiB (1%) 132
["OptAnalyzer", "println(QuoteNode(nothing))"] 412.308 ms (5%) 244.35 MiB (1%) 4563388
["OptAnalyzer", "rand(Bool)"] 27.036 ms (5%) 16.52 MiB (1%) 331464
["OptAnalyzer", "sum(\"julia\") (cached)"] 215.124 μs (5%) 61.38 KiB (1%) 990
["OptAnalyzer", "sum(\"julia\")"] 11.968 ms (5%) 7.68 MiB (1%) 151221
["show(::IO, ::JETCallResult)", "report_call"] 3.774 ms (5%) 1.14 MiB (1%) 9485
["show(::IO, ::JETCallResult)", "report_opt"] 15.749 μs (5%) 728 bytes (1%) 19

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["First-Time-To-JET"]
  • ["JETAnalyzer{BasicPass} top-level"]
  • ["JETAnalyzer{BasicPass}"]
  • ["JETAnalyzer{SoundPass}"]
  • ["OptAnalyzer"]
  • ["show(::IO, ::JETCallResult)"]

Julia versioninfo

Julia Version 1.11.0-DEV.1079
Commit e39e77fa9eb (2023-12-11 23:12 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.3 LTS
 uname: Linux 6.2.0-1018-azure #18~22.04.1-Ubuntu SMP Tue Nov 21 19:25:02 UTC 2023 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 2445 MHz 4338 s 0 s 285 s 10038 s 0 s
 #2 2445 MHz 3189 s 0 s 294 s 11179 s 0 s
 #3 3242 MHz 3768 s 0 s 312 s 10583 s 0 s
 #4 3258 MHz 3617 s 0 s 287 s 10754 s 0 s
 Memory: 15.60690689086914 GB (11240.76953125 MB free)
 Uptime: 1470.91 sec
 Load Avg: 1.08 1.08 0.92
 WORD_SIZE: 64
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
 Threads: 1 on 4 virtual cores

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() lbt
Sys.CPU_THREADS 4

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 48 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 4
On-line CPU(s) list: 0-3
Vendor ID: AuthenticAMD
Model name: AMD EPYC 7763 64-Core Processor
CPU family: 25
Model: 1
Thread(s) per core: 2
Core(s) per socket: 2
Socket(s): 1
Stepping: 1
BogoMIPS: 4890.84
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization: AMD-V
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 1 MiB (2 instances)
L3 cache: 32 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Mitigation; safe RET, no microcode
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines, STIBP disabled, RSB filling, PBRSB-eIBRS Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected

Cpu Property Value
Brand AMD EPYC 7763 64-Core Processor
Vendor :AMD
Architecture :Unknown
Model Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores 16 physical cores, 16 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 512, 32768) kbytes
64 byte cache line size
Address Size 48 bits virtual, 48 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@aviatesk aviatesk merged commit 8a69a9a into master Dec 12, 2023
20 of 25 checks passed
@aviatesk aviatesk deleted the avi/581 branch December 12, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aviatesk @codecov-commenter