Use suggestions API for no-only-test and no-skip-test
#325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sindresorhus Integration tests are failing in the same way as they did in #324. Was the build already broken? |
|
You need to update the rule docs and the readme. |
Drop |
|
Done (oh yay, the integration test is working now too!) |
sindresorhus
changed the title
no-only-test and no-skip-test
|
Thanks! If you don't mind my asking, any idea when this might be released? I'm very much looking forward to updating this plugin on my services. |
|
It was released half an hour ago. |
|
Oh, double-thanks then! Keep up the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #324
#281 (comment)