Add `no-error-ctor-with-notthrows` rule #240

rahgurung · 2019-05-03T17:27:02Z

fixes #178
added rule with tests (100% coverage).

sindresorhus · 2019-05-05T14:26:30Z

Please read and adhere to https://github.com/avajs/eslint-plugin-ava/blob/master/docs/new-rule.md (Probably smart to read it multiple times as it's easy to miss something).

The rule needs a more specific name that follows the naming convention of the other rules.

rules/prevent-errortype.js

test/prevent-errortype.js

rules/prevent-errortype.js

rahgurung · 2019-05-05T16:36:08Z

@novemberborn @sindresorhus can you guys suggest a better name? I think we can go with - no-errortype-with-tnotthrows. It's a little long name but is quite self-explanatory.

rahgurung · 2019-05-08T08:44:39Z

@sindresorhus

novemberborn · 2019-05-08T08:50:35Z

@gurungrahul2 thanks for the updates. We do get notifications when commits are pushed so there's no need to remind us. It just may take some time before we can get back to you.

rahgurung · 2019-05-08T09:09:44Z

Sorry @novemberborn , i will take care.

sindresorhus · 2019-05-14T07:42:50Z

You missed this:

(The description should be the same as the heading of the documentation file).

And:

Add the correct meta.type to the rule.

https://github.com/avajs/eslint-plugin-ava/blob/master/docs/new-rule.md

sindresorhus · 2019-05-14T07:45:09Z

The rule should handle .notThrowsAsync too.

sindresorhus · 2019-05-14T07:47:25Z

With #240 (comment), I meant they would be more readable if you format them like normal code, using multiple lines.

docs/rules/no-typeerror-with-notthrows.md

index.js

rules/no-typeerror-with-notthrows.js

rahgurung · 2019-07-08T13:53:21Z

Can this be more better?

sindresorhus · 2019-07-09T08:57:52Z

I haven't forgotten about this. I just haven't had the chance to review it properly yet. Maybe @JLHwung and @GMartigny have time to help review.

readme.md

rules/no-error-ctor-with-notthrows.js

test/no-error-ctor-with-notthrows.js

rules/no-error-ctor-with-notthrows.js

test/no-error-ctor-with-notthrows.js

rules/no-error-ctor-with-notthrows.js

changed name of test and added more tests with other requested changes.

defined variables just before they are used and added more tests

added more checks as guided

rahgurung · 2019-09-12T04:19:59Z

Review ping. :) @sindresorhus

GMartigny · 2020-12-07T11:32:05Z

readme.md

@@ -84,6 +85,7 @@ The rules will only activate in test files.
 - [no-async-fn-without-await](docs/rules/no-async-fn-without-await.md) - Ensure that async tests use `await`.
 - [no-cb-test](docs/rules/no-cb-test.md) - Ensure no `test.cb()` is used.
 - [no-duplicate-modifiers](docs/rules/no-duplicate-modifiers.md) - Ensure tests do not have duplicate modifiers.
+- [no-error-ctor-with-notthrows](docs/rules/no-error-ctor-with-notthrows.md) - No specifying error type in `t.notThrows()`.


Suggested change

- [no-error-ctor-with-notthrows](docs/rules/no-error-ctor-with-notthrows.md) - No specifying error type in `t.notThrows()`.

- [no-error-ctor-with-notthrows](docs/rules/no-error-ctor-with-notthrows.md) - Ensure no error constructor is specified in `t.notThrows()`.

GMartigny · 2020-12-07T11:34:36Z

test/no-error-ctor-with-notthrows.js

+
+const errors = [{ruleId: 'no-error-ctor-with-notthrows'}];
+
+const header = `const test = require('ava');\n`; // eslint-disable-line quotes


Suggested change

const header = `const test = require('ava');\n`; // eslint-disable-line quotes

const header = 'const test = require(\'ava\');\n';

GMartigny · 2020-12-07T11:43:55Z

test/no-error-ctor-with-notthrows.js

+ruleTester.run('no-error-ctor-with-notthrows', rule, {
+	valid: [
+		`${header}
+		test('some test',t => {


Suggested change

test('some test',t => {

test('some test', t => {

Could you fix this for all the other times ?

GMartigny · 2020-12-07T11:51:47Z

package.json

@@ -62,7 +62,7 @@
 	"ava": {
 		"files": [
 			"!rules",
-			"test/*.js"
+			"test/*js"


Suggested change

"test/*js"

"test/*.js"

Why change this ?

sindresorhus · 2021-03-24T13:35:43Z

Closing for lack of activity.

rahgurung mentioned this pull request May 3, 2019

Prevent specifying error type in t.notThrows() #178

Open

rahgurung force-pushed the 178 branch from 4bb422c to 827ad45 Compare May 3, 2019 17:36

novemberborn requested a review from sindresorhus May 5, 2019 14:22

sindresorhus requested changes May 5, 2019

View reviewed changes

rules/prevent-errortype.js Outdated Show resolved Hide resolved

test/prevent-errortype.js Outdated Show resolved Hide resolved

test/prevent-errortype.js Outdated Show resolved Hide resolved

rules/prevent-errortype.js Outdated Show resolved Hide resolved

rahgurung changed the title ~~rule prevent-errortype~~ Add no-typeerror-with-notthrows May 5, 2019

rahgurung changed the title ~~Add no-typeerror-with-notthrows~~ Add no-typeerror-with-notthrows rule May 5, 2019

sindresorhus requested changes May 14, 2019

View reviewed changes

docs/rules/no-typeerror-with-notthrows.md Outdated Show resolved Hide resolved

index.js Outdated Show resolved Hide resolved

rules/no-typeerror-with-notthrows.js Outdated Show resolved Hide resolved

rahgurung force-pushed the 178 branch from e9679fd to 2d86d15 Compare May 14, 2019 18:52

rahgurung changed the title ~~Add no-typeerror-with-notthrows rule~~ Add no-error-ctor-with-notthrows rule May 14, 2019

GMartigny suggested changes Jul 9, 2019

View reviewed changes

GMartigny approved these changes Jul 9, 2019

View reviewed changes

JLHwung suggested changes Jul 9, 2019

View reviewed changes

rules/no-error-ctor-with-notthrows.js Show resolved Hide resolved

rules/no-error-ctor-with-notthrows.js Show resolved Hide resolved

rules/no-error-ctor-with-notthrows.js Outdated Show resolved Hide resolved

rahgurung added 7 commits July 12, 2019 16:03

rule prevent-errortype

6604155

feedback - I

0c8b003

changed name of test and added more tests with other requested changes.

feedback

0a968d4

changed name to no-error-ctor-with-notthrows

66a5e99

feedback

d754d0a

defined variables just before they are used and added more tests

wip

dcd4357

feedback

02a2c8f

added more checks as guided

rahgurung force-pushed the 178 branch from 91c0c04 to 02a2c8f Compare July 27, 2019 07:40

JLHwung approved these changes Jul 27, 2019

View reviewed changes

Merge branch 'master' into 178

eb5e7d3

GMartigny suggested changes Dec 7, 2020

View reviewed changes

Base automatically changed from master to main January 23, 2021 07:39

sindresorhus closed this Mar 24, 2021

GMartigny mentioned this pull request Mar 24, 2021

Add no-error-ctor-with-notthrows rule #326

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `no-error-ctor-with-notthrows` rule #240

Add `no-error-ctor-with-notthrows` rule #240

rahgurung commented May 3, 2019 •

edited

Loading

sindresorhus commented May 5, 2019

rahgurung commented May 5, 2019

rahgurung commented May 8, 2019

novemberborn commented May 8, 2019

rahgurung commented May 8, 2019

sindresorhus commented May 14, 2019 •

edited

Loading

sindresorhus commented May 14, 2019

sindresorhus commented May 14, 2019

rahgurung commented Jul 8, 2019

sindresorhus commented Jul 9, 2019

rahgurung commented Sep 12, 2019

GMartigny Dec 7, 2020

GMartigny Dec 7, 2020

GMartigny Dec 7, 2020

GMartigny Dec 7, 2020

sindresorhus commented Mar 24, 2021

	- [no-error-ctor-with-notthrows](docs/rules/no-error-ctor-with-notthrows.md) - No specifying error type in `t.notThrows()`.
	- [no-error-ctor-with-notthrows](docs/rules/no-error-ctor-with-notthrows.md) - Ensure no error constructor is specified in `t.notThrows()`.


		const errors = [{ruleId: 'no-error-ctor-with-notthrows'}];

		const header = `const test = require('ava');\n`; // eslint-disable-line quotes

	const header = `const test = require('ava');\n`; // eslint-disable-line quotes
	const header = 'const test = require(\'ava\');\n';

Add no-error-ctor-with-notthrows rule #240

Add no-error-ctor-with-notthrows rule #240

Conversation

rahgurung commented May 3, 2019 • edited Loading

sindresorhus commented May 5, 2019

rahgurung commented May 5, 2019

rahgurung commented May 8, 2019

novemberborn commented May 8, 2019

rahgurung commented May 8, 2019

sindresorhus commented May 14, 2019 • edited Loading

sindresorhus commented May 14, 2019

sindresorhus commented May 14, 2019

rahgurung commented Jul 8, 2019

sindresorhus commented Jul 9, 2019

rahgurung commented Sep 12, 2019

GMartigny Dec 7, 2020

Choose a reason for hiding this comment

GMartigny Dec 7, 2020

Choose a reason for hiding this comment

GMartigny Dec 7, 2020

Choose a reason for hiding this comment

GMartigny Dec 7, 2020

Choose a reason for hiding this comment

sindresorhus commented Mar 24, 2021

Add `no-error-ctor-with-notthrows` rule #240

Add `no-error-ctor-with-notthrows` rule #240

rahgurung commented May 3, 2019 •

edited

Loading

sindresorhus commented May 14, 2019 •

edited

Loading