[typescript] added missing todo definition

[andischerer]

Hey guys,
first of all thanks for this awesome testrunner.

I've added the missing todo definition to the index.d.ts.

[jamestalmage]

@SamVerschueren

[sindresorhus]

We also need to add test.failing. Anything else that needs updating?

[sindresorhus]

// @ivogabe

[jamestalmage]

It would be good to land this as part of the upcoming release as well.

[ivogabe]

Does todo allow chaining? This definition doesn't allow it.

[jamestalmage]

Yes. The only checks against todo are here.

• It can't contain an implementation.
• It must have a title

[SamVerschueren]

Seems ok, not much to it :).

[jamestalmage]

@SamVerschueren Does it need something additional to enable chaining?

[SamVerschueren]

Yes, this will only allow you to write test.todo('message'). But todo doesn't allow chaining right?

[jamestalmage]

But todo doesn't allow chaining right

We aren't actively preventing it, but I can't really think of a reason you ever would:

test.serial.todo
test.after.todo

None of those make any sense. Maybe we should prevent modifiers on a todo

[jamestalmage]

Merging. We can debate what to do about todo chaining in #847.

[sindresorhus]

@ivogabe @SamVerschueren Could either of you add test.failing?

https://github.com/avajs/ava#failing-tests

[SamVerschueren]

Yeah sure.

[jamestalmage]

While you are at it, I think there's an error when it comes to using test.serial.

test.serial tests are allowed to return a promise, or have callbacks.

test.serial.cb is totally allowed, as is test.serial(promiseReturning).

The point of test.serial, is that it makes the tests run independently without contention. .serial tests are run first, and one at a time, whereas the default is to run with max concurrency. They are allowed to be async, via .cb or returning a Promise/Observable.

Right now, it looks like .serial tests are not allowed to return a promise, and that .cb.serial and .serial.cb are invalid chains.

[SamVerschueren]

I think you're right (not tested yet). It looks like test.serial.cb is not defined.