Remove marshaling from transfer action #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samliok
commented
Oct 9, 2024
| @@ -33,7 +33,7 @@ func init() { | |||
| errs.Add( | |||
| // When registering new actions, ALWAYS make sure to append at the end. | |||
| // Pass nil as second argument if manual marshalling isn't needed (if in doubt, you probably don't) | |||
| ActionParser.Register(&actions.Transfer{}, actions.UnmarshalTransfer), | |||
| ActionParser.Register(&actions.Transfer{}, nil), | |||
There was a problem hiding this comment.
confused by the register function. It uses avalanchego's linearcodec, so where does the new abi package play into here?
Line 40 in a230d1b
There was a problem hiding this comment.
It is responsible for defining structs so they can be transferred between languages. If all implementations were in Golang, we wouldn't need an ABI.
containerman17
requested changes
Oct 10, 2024
I'm alright with dropping this from the docs for now. I don't think anybody should be using this for now and we can either deprecate it completely or add to the docs in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not needed any more because we can just use the ABI package to provide the correct format