Modularize database initialization #65
Conversation
rkuris
requested review from
exdx,
xinifinity,
gyuho,
hexfusion,
patrick-ogrady and
StephenButtolph
as code owners
rkuris
force-pushed
the
rkuris/modularize-db-init
branch
from
b599f27
to
3b2b091
Compare
rkuris
force-pushed
the
rkuris/modularize-db-init
branch
from
5049ed7
to
83408fe
Compare
rkuris
force-pushed
the
rkuris/modularize-db-init
branch
7 times, most recently
from
83c878c
to
6d3da4d
Compare
rkuris
removed request for
hexfusion,
gyuho,
patrick-ogrady,
StephenButtolph and
exdx
| @@ -180,7 +180,7 @@ impl RevisionTracker { | |||
| fn get_revision(&self, index: usize) -> Revision<SharedStore> { | |||
| self.db | |||
| .get_revision(&self.hashes[index], None) | |||
| .expect(&format!("revision-{index} should exist")) | |||
| .unwrap_or_else(|| panic!("revision-{index} should exist")) | |||
There was a problem hiding this comment.
Wondering why the change, is unwrap_or_else is better than expect?
There was a problem hiding this comment.
This was recommended by clippy with a few extra warnings turned on. Reason: format is built into panic, and it won't evaluate/compute the string until the panic actually happens (I think, not 100% sure)
There was a problem hiding this comment.
| @@ -581,9 +579,12 @@ impl DiskBufferRequester { | |||
| } | |||
|
|
|||
| /// Initialize the Wal. | |||
| pub fn init_wal(&self, waldir: &str, rootpath: PathBuf) { | |||
| pub fn init_wal(&self, waldir: &str, rootpath: &Path) { | |||
There was a problem hiding this comment.
Why do we change this to &Path as downstream is PathBuf?
There was a problem hiding this comment.
The answer was in the commit comment for the second commit, probably not easy to find. The idea is that I want to defer cloning the dbpath because I want it after init_wal is finished.
There was a problem hiding this comment.
Allocation should be explicit, not hidden. I don't quite understand the motivation here.
rkuris
force-pushed
the
rkuris/modularize-db-init
branch
2 times, most recently
from
35ac003
to
6dc0fbb
Compare
This moves DBConfig and DBRevConfig into a new config dir allowing these configs to be fetched from elsewhere
Want access to it after the last init_wal for better errors
rkuris
force-pushed
the
rkuris/modularize-db-init
branch
from
6dc0fbb
to
2d3d5e2
Compare
Pretty tough to implement v2 of the API since things are so tied to the db implementation.
This group of commits splits the db.rs file into parts, documenting the opening of the database as I go.