Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade nix #226

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Upgrade nix #226

merged 3 commits into from
Aug 28, 2023

Commits on Aug 28, 2023

  1. Upgrade nix 

    Two major changes:
 - features must be included; we only need two (this will speed up
   compiles!)
 - FD safety; we now need an OwnedFd, so attempting to use the fd after
   the object is dropped is no longer valid. Additionally, we don't need
   to implement Drop, as OwnedFd already has a drop which calls close

References:

 * nix-rust/nix#2091 - nix PR for features drop
 * https://doc.rust-lang.org/stable/src/std/os/fd/owned.rs.html#170-182 - OwnedFd docs
 * nix-rust/nix#1906 - nix PR for FD I/O safety
    @rkuris
    rkuris committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f44fed1 View commit details
    Browse the repository at this point in the history

  2. Lint

    @rkuris
    rkuris committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9533d4c View commit details
    Browse the repository at this point in the history

  3. Move Target to top of impl block 

    Per review comments
    @rkuris
    rkuris committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    429d382 View commit details
    Browse the repository at this point in the history