Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node type to api + proofs #225

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Add node type to api + proofs #225

merged 3 commits into from
Aug 28, 2023

Conversation

rkuris
Copy link
Collaborator

@rkuris rkuris commented Aug 28, 2023

Proofs need to how to fetch data from a node they are operating on.

@rkuris
Add node type to api + proofs
9280fab 
Proofs need to how to fetch data from a node they are operating on.
@rkuris rkuris marked this pull request as ready for review August 28, 2023 16:28
richardpringle
richardpringle requested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@richardpringle richardpringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constraints should always be minimal. If we need to add constraints when it comes to implementation, we can add more constraints then.

firewood/src/v2/api.rs Outdated Show resolved Hide resolved
firewood/src/v2/api.rs Outdated Show resolved Hide resolved
firewood/src/v2/db.rs Outdated Show resolved Hide resolved
firewood/src/v2/emptydb.rs Outdated Show resolved Hide resolved
firewood/src/v2/propose.rs Outdated Show resolved Hide resolved
@rkuris rkuris merged commit 0e48de6 into main Aug 28, 2023
5 checks passed
@rkuris rkuris deleted the rkuris/proof-node-type-deets branch August 28, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardpringle richardpringle richardpringle approved these changes

@xinifinity xinifinity Awaiting requested review from xinifinity

Assignees
No one assigned
Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkuris @richardpringle