Rkuris/nibbles iterative improvement #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to get ahead of future stable lint snags. This one found a few inefficient memory initializations and some useless statements.
Per review comments
…d into rkuris/clip-on-clip-off
I need DoubleEndedIterator for a later diff, but I found that implementing these interfaces forced some optimization of Nibbles. Implenting DoubleEndedIterator improved performance by precomputing the constant maximum index offset and storing it. This means the Iterator type is 4 bytes larger, but this seems like a good tradeoff. Implementing `FusedIterator` also improved performance in two ways: - Calling `next()` does not increment pos if you're already at the end - The `is_empty()` check is now an equals rather than a greater or equal But these implementations have some great benefits: - Additional methods like rev() are now available to iterate backwards - `fused()` on the iterator is now a no-op
Signed-off-by: Ron Kuris <[email protected]>
richardpringle
approved these changes
Aug 25, 2023
xinifinity
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nibbles: impl FusedIterator + DoubleEndedIterator
I need DoubleEndedIterator for a later diff, but I found that implementing these interfaces forced some optimization of Nibbles.