Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of rev.rs #217

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Cleanup of rev.rs #217

merged 3 commits into from
Aug 25, 2023

Conversation

xinifinity
Copy link
Contributor

nits followup from #188.

rkuris
rkuris approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@rkuris rkuris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, otherwise looks good

firewood/examples/rev.rs Outdated Show resolved Hide resolved
@xinifinity xinifinity merged commit 1512fe6 into main Aug 25, 2023
5 checks passed
@xinifinity xinifinity deleted the rev_nits branch August 25, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkuris rkuris rkuris approved these changes

@richardpringle richardpringle richardpringle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinifinity @rkuris @richardpringle