Use v2::api::Proof<V> over proof::Proof #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkuris
force-pushed
the
rkuris/bullet-proof-generics
branch
from
adc8370
to
510388d
Compare
Right now we just use Vec<[u8]> but it would be nifty to have proofs that can share node storage via references instead of allocating space for them.
rkuris
force-pushed
the
rkuris/bullet-proof-generics
branch
from
d0e0308
to
87511de
Compare
rkuris
changed the title
richardpringle
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds generics for the storage of the nodes. It would be amazing if the proof shared the node storage with the actual node in shale, and this is one step toward getting us there.
Additionally, in order to implement the new v2 api we need proofs to be the new proofs