integrate ACP-118 #408
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,17 +16,17 @@ import ( | |
| "github.com/ava-labs/avalanchego/ids" | ||
| "github.com/ava-labs/avalanchego/message" | ||
| "github.com/ava-labs/avalanchego/proto/pb/p2p" | ||
| "github.com/ava-labs/avalanchego/proto/pb/sdk" | ||
| "github.com/ava-labs/avalanchego/subnets" | ||
| "github.com/ava-labs/avalanchego/utils/crypto/bls" | ||
| "github.com/ava-labs/avalanchego/utils/logging" | ||
| "github.com/ava-labs/avalanchego/utils/set" | ||
| avalancheWarp "github.com/ava-labs/avalanchego/vms/platformvm/warp" | ||
| "github.com/ava-labs/awm-relayer/peers" | ||
| "github.com/ava-labs/awm-relayer/utils" | ||
| msg "github.com/ava-labs/subnet-evm/plugin/evm/message" | ||
| "go.uber.org/zap" | ||
| "google.golang.org/protobuf/proto" | ||
| ) | ||
|
|
||
| type blsSignatureBuf [bls.SignatureLen]byte | ||
|
|
@@ -40,9 +40,6 @@ const ( | |
| ) | ||
|
|
||
| var ( | ||
| // Errors | ||
| errNotEnoughSignatures = errors.New("failed to collect a threshold of signatures") | ||
| errNotEnoughConnectedStake = errors.New("failed to connect to a threshold of stake") | ||
|
|
@@ -76,6 +73,7 @@ func NewSignatureAggregator( | |
|
|
||
| func (s *SignatureAggregator) CreateSignedMessage( | ||
| unsignedMessage *avalancheWarp.UnsignedMessage, | ||
| justification []byte, | ||
| inputSigningSubnet ids.ID, | ||
| quorumPercentage uint64, | ||
| ) (*avalancheWarp.Message, error) { | ||
|
|
@@ -122,19 +120,9 @@ func (s *SignatureAggregator) CreateSignedMessage( | |
| return nil, errNotEnoughConnectedStake | ||
| } | ||
|
|
||
| reqBytes, err := proto.Marshal( | ||
| &sdk.SignatureRequest{Message: unsignedMessage.Bytes()}, | ||
|
There was a problem hiding this comment. We should add justification bytes here as well as the API. In the API they should be hex encoded and since their meaning is VM specific we don't need to do any processing to them either just like with the message. We should only pass the non-zero fields since the ACP-118 spec but in the API layer we should do validation that at least one of I would also rename our API to use There was a problem hiding this comment. addressed in 557262a There was a problem hiding this comment. This isn't done yet. I added the justification everywhere (in the API) except for right here 😅 There was a problem hiding this comment. last piece addressed in 29cac30 |
||
| ) | ||
| if err != nil { | ||
| msg := "Failed to marshal request bytes" | ||
| s.logger.Error( | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule teleporter
updated
191 files
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasn't too clear to me what this
justificationfield is meant for, and why it's always emptyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Justification field is part of ACP-118 It's unused for now but is meant to be potentially extra data that would explain why the data in the message field should be signed. It's unused for now though so that's why it's always empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we can't just pass in
nilhere? Allocating a slice that's never assigned to seems odd.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in 6cd8245