[proto] update protocol version 28 #23
Conversation
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
|
Not sure what is up with docs and conformance tests cc @exdx |
Signed-off-by: Sam Batschelet <[email protected]>
|
Proto p2p updates broke message, will resolve in a bit. |
hexfusion
added
dependencies
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
| @@ -94,10 +94,6 @@ prometheus = { version = "0.13.3", default-features = false, features = ["proces | |||
| base64 = { version = "0.21.2", optional = true } # https://github.com/marshallpierce/rust-base64 | |||
| num-bigint = { version = "0.4.3", optional = true } | |||
|
|
|||
| [build-dependencies] | |||
| protoc-gen-prost = "0.2.3" | |||
| protoc-gen-tonic = "0.3.0" | |||
There was a problem hiding this comment.
now using community plugins which are hosted by buf
Signed-off-by: Sam Batschelet <[email protected]>
Signed-off-by: Sam Batschelet <[email protected]>
There was a problem hiding this comment.
This needs to be hidden behind #[cfg(tests)]
There was a problem hiding this comment.
All of these clients should probably be behind feature flags. All this code is probably hurting compile times when it's unlikely that the majority of it is being used.
There was a problem hiding this comment.
But we can tackle it in a followup
There was a problem hiding this comment.
We had it that way but it was a lot of features. It does support this.
| ]; | ||
| include!("sync.tonic.rs"); |
There was a problem hiding this comment.
🤔 .... Does this mean that the whole client implementation is included here?
There was a problem hiding this comment.
not the client implementation just the client types.
There was a problem hiding this comment.
I don't think so. If you look at that file, it's a full-fledged gRPC client implementation for the sync-service.
There was a problem hiding this comment.
Why are both the proto-files and the generated code checked into source control? We only need one or the other as code generation is deterministic.
There was a problem hiding this comment.
I think it makes sense as verification of the diff but would not be explicitly required.
This PR adds support for protocol version 28 and AvalancheGo v1.10.9+. It also bumps
protoc-gen-tonicgenerated code to v0.3.0 andprotoc-gen-prostto v0.2.3 and moves them to the community hosted plugins provided by buf. This is a new feature and means that buf does not require the plugins locally to generate code.The large diff is caused by an update in
protoc-gen-prostto support tonic0.9which added support forThis requires all protos to be regenerated.
neoeinstein/protoc-gen-prost#72