Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(.github): split docker-build-and-push step to no-cuda and cuda steps #5414

Closed
wants to merge 6 commits into from

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Nov 8, 2024

Description

This PR divides the docker-build-and-push step into two steps to further mitigate disk space issues. Unfortunately, this increases the runtime since actions like vcs import need to be performed twice.

Tests performed

https://github.com/autowarefoundation/autoware/actions/runs/11740552604
https://github.com/autowarefoundation/autoware/actions/runs/11740558218

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk self-assigned this Nov 8, 2024
@xmfcx xmfcx closed this Nov 8, 2024
@xmfcx xmfcx reopened this Nov 8, 2024
@xmfcx xmfcx closed this Nov 8, 2024
@xmfcx xmfcx reopened this Nov 8, 2024
@youtalk youtalk added type:github-actions Github actions related. (auto-assigned) tag:run-health-check Run health-check labels Nov 8, 2024
@youtalk youtalk marked this pull request as ready for review November 8, 2024 13:29
@youtalk youtalk changed the title feat(.github): split docker-build-and-push job to no-cuda and cuda steps feat(.github): split docker-build-and-push step to no-cuda and cuda steps Nov 8, 2024
@youtalk youtalk closed this Nov 11, 2024
@youtalk youtalk deleted the upstream-split-no-cuda-cuda-jobs branch November 11, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check type:github-actions Github actions related. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants