Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completing missing parameters on vehicle dimensions page #175

Open
3 tasks done
senagolcuk opened this issue Jul 27, 2022 · 1 comment
Open
3 tasks done

completing missing parameters on vehicle dimensions page #175

senagolcuk opened this issue Jul 27, 2022 · 1 comment
Labels
priority:high High urgency and importance. status:stale Inactive or outdated issues. (auto-assigned) type:documentation Creating or refining documentation.

Comments

@senagolcuk
Copy link

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Some parameters in the sample_vehicle_launch package are missing on page Vehicle Dimensions. Parameters without description are listed below.

vehicle_info.param.yaml

  • wheel_tread
  • vehicle_height
  • max_steer_angle

simulator_model.param.yaml

  • simulated_frame_id
  • origin_frame_id
  • vehicle_model_type
  • initialize_source
  • timer_sampling_time_ms
  • add_measurement_noise
  • vel_lim
  • vel_rate_lim
  • steer_lim
  • steer_rate_lim
  • acc_time_delay
  • acc_time_constant
  • steer_time_delay
  • steer_time_constant
  • x_stddev
  • y_stddev

mirror.param.yaml

  • min_longitudinal_offset
  • max_longitudinal_offset
  • min_lateral_offset
  • max_lateral_offset
  • min_height_offset
  • max_height_offset

Purpose

Adding comments makes documentation easy to follow.

Possible approaches

Adding all the parameters that belong to the packages.

Definition of done

Adding all the parameters that belong to the packages.

@senagolcuk senagolcuk added type:documentation Creating or refining documentation. priority:high High urgency and importance. labels Jul 27, 2022
@stale
Copy link

stale bot commented Sep 25, 2022

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High urgency and importance. status:stale Inactive or outdated issues. (auto-assigned) type:documentation Creating or refining documentation.
Projects
None yet
Development

No branches or pull requests

1 participant