Fixed kpartx delete partition mapping test #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem Description : After executing the kpartx -d command, there was a minor delay to capture the required string hence the failure occurred. Fix : Modified the code to wait for max 10 seconds to get the string and then continue with the execution. Signed-off By: Kowshik Jois <[email protected]>
| @@ -86,7 +86,8 @@ function run_kpartx_tests() | |||
|
|
|||
| tc_register "Test kpartx -d" | |||
| kpartx -d $kpartx_img >$stdout 2>$stderr | |||
| grep "loop deleted" $stdout | grep -q /dev/$loopdev | |||
| # wait for max 10 sec to update | |||
| tc_wait_for_file_text $stdout "loop deleted : /dev/$loopdev" | |||
| tc_fail_if_bad $? "kpartx -d fail1" || return | |||
There was a problem hiding this comment.
If you can add the failure string that comes in stderr , it gives a better understanding why the change is required.
Few things:
-
Can we add a check for "kpartx -d" first ?
kpartx -d $kpartx_img >$stdout 2>$stderr
tc_fail_if_bad $? "kpartx -d failed" || return -
Followed by verifying the expected message in stdout
tc_wait_for_file_text $stdout "loop deleted : /dev/$loopdev"
Also correct the error mesage: "kpartx -d fail1"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description :
After executing the kpartx -d command, there was a minor delay to capture the required string hence the failure occurred.
Fix :
Modified the code to wait for 10 seconds to get the string and then continue with the execution.
Signed-off By: Kowshik Jois [email protected]