Modifed existing code to work on ubuntu environment. #120
Conversation
Updated the wrapper-script to ignore the warnings in stderr, because of which the tests are failing on Ubuntu environment. Signed-off-by: Rajashree Rajendran <[email protected]>
| tc_fail_if_bad $? "unexpected response" || return | ||
| RC=$? | ||
| [ $RC -eq 0 ] && tc_ignore_warnings "Unescaped left brace in regex is deprecated, passed through" | ||
|
|
There was a problem hiding this comment.
It appears to me that this error comes from perl ( version 5.22 ) and this is fixed in later version of perl.
And it can be fixed by escaping '{'. Can you please verify if this needs to ignored only for this version of perl ?
Please modify summary to be more precise on the changes.
For each of the changes, better to add in the comments on why it is happening in ubuntu environment specifically. like package/environment changes ?
| RC=$? | ||
| if [ $tst = "fnamedat" ] || [ $tst = "fnarray" ] || [ $tst = "fnarray2" ] || [ $tst = "fnarydel" ] || [ $tst = "fnasgnm" ] || [ $tst = "fnparydl" ] || [ $tst = "funsmnam" ] || [ $tst = "gsubasgn" ] || [ $tst = "parseme" ] || [ $tst = "badargs" ] || [ $tst = "match2" ] && [ $RC -eq 0 ]; then | ||
| tc_ignore_warnings "make:" | ||
| fi |
There was a problem hiding this comment.
tc_ignore_warnings "make:" and tc_ignore_warnings "ar:"
This will result in ignoring anything with "make/ar" ( which may be an error and we may miss ) in future. So makes sense to use proper warning messages instead of using just "make" or "ar" .
| @@ -55,6 +55,7 @@ function TC_libxml2() | |||
| if [ $? == 1 ]; then | |||
| cat /dev/null > $stderr | |||
| fi | |||
| [ $? -eq 0 ] && tc_ignore_multiple_warnings "Missing result file result/errors/" | |||
| tc_pass_or_fail $? "libxml2 runtest failure" | |||
There was a problem hiding this comment.
Please correct above to use right error code.
ltrace - ltrace -L -S output was different in Ubuntu. Modified script to grep for SYS_open instead of open@SYS mlocate - crond service in Ubuntu is cron service. Updated the wrapper to check for cron instead of crond Signed-off-by: Rajashree Rajendran <[email protected]>
rajashreer7
force-pushed
the
Ubuntu_changes
branch
from
685518e
to
590bdbc
Compare
Updated the wrapper-script to ignore the warnings in stderr, because of which the tests are failing on Ubuntu environment.
Signed-off-by: Rajashree Rajendran [email protected]