rng-tools: Fix for rngd daemon failing to start #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated wrapper-script to check if the tpm device is available in the machine, since rng service works on this device. If the device is not available, the test is skipped else the service is started and test excutes. Signed-off-by: Rajashree Rajendran <[email protected]>
| @@ -43,14 +44,10 @@ rng_service=rngd | |||
| # | |||
| function tc_local_setup() | |||
| { | |||
| tc_register "Setting up machine to run the tests" | |||
| tc_root_or_break || return | |||
There was a problem hiding this comment.
tc_register will register "Setting up machine to run the tests" as one test and increment TST_TOTAL , but I dont see corresponding tc_pass*/tc_fail* associated to this. If intention is put info in logs, you can use tc_info "Setting up machine to run the tests"
|
|
||
| tc_register "checking TPM device" | ||
| tc_exists /dev/random /dev/urandom /dev/tpm* | ||
| if [ $? -ne 0 ]; then |
There was a problem hiding this comment.
Few doubts here:
Evenif /dev/tpm is not present , random number generator works with /dev/urandom or with /dev/hwrng.
I could verify in system which doesnt have /dev/tpm and successfully start rngd using "rngd -f"
Can you please verify again if /dev/tpm is must here.
| fi | ||
| fi | ||
| systemctl is-active rngd 2>&1 >/dev/null | ||
| [ $? -eq 0 ] && \ |
There was a problem hiding this comment.
tc_service* can be used here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated wrapper-script to check if the tpm device is available in
the machine, since rng service works on this device. If the device
is not available, the test is skipped else the service is started
and test excutes.
Signed-off-by: Rajashree Rajendran [email protected]