Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in path.py #1198

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Fix bug in path.py #1198

merged 1 commit into from
Sep 15, 2024

Conversation

zlite
Copy link
Contributor

@zlite zlite commented Sep 14, 2024 •
edited
Loading

Should return three values, but in the case of None it only returned two, causing an error. Thanks to Dirk for debugging

@zlite zlite requested a review from Ezward September 14, 2024 23:36
@zlite zlite self-assigned this Sep 14, 2024
DocGarbanzo
DocGarbanzo approved these changes Sep 15, 2024
View reviewed changes
Copy link
Contributor

@DocGarbanzo DocGarbanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, that's what we checked during the call.

@DocGarbanzo DocGarbanzo merged commit 5483490 into main Sep 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DocGarbanzo DocGarbanzo DocGarbanzo approved these changes

@Ezward Ezward Awaiting requested review from Ezward

Assignees

@zlite zlite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zlite @DocGarbanzo