fix cv color conversions #1133
Merged
fix cv color conversions #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ezward
commented
Jun 24, 2023
Ezward
commented
- several of the color conversions were not correctly returning the converted image; returning None instead. This caused a crash when they were used.
- this commit fixes those and makes all color conversions similar in how they return that converted image
- This also adds a new transform; a version of the trapezoid mask that takes values from the edges of the image like the crop transform does (rather than absoluted image coordinates as the pre-existing trapezoid transform does).
- several of the color conversions were not correctly returning the converted image; return None instead. - this commit fixes those and makes all color conversions similar in how they return that converted image - This also adds a new transform; a version of the trapezoid mask that takes values from the edges of the image like the crop transform does (rather than absoluted image coordinates as the pre-existing trapezoid transform does).
haslinghuis
reviewed
Jun 25, 2023
Comment on lines
+457
to
+459
| cv2.fillConvexPoly(mask, | ||
| np.array(points, dtype=np.int32), | ||
| self.fill) |
There was a problem hiding this comment.
👾
Suggested change
| cv2.fillConvexPoly(mask, | |
| np.array(points, dtype=np.int32), | |
| self.fill) | |
| cv2.fillConvexPoly( | |
| mask, | |
| np.array(points, dtype=np.int32), | |
| self.fill | |
| ) |
Suggested change
| cv2.fillConvexPoly(mask, | |
| np.array(points, dtype=np.int32), | |
| self.fill) | |
| cv2.fillConvexPoly(mask, np.array(points, dtype=np.int32), self.fill) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.