-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StopSign and Cone Detection #1131
base: tf_2_9
Are you sure you want to change the base?
Conversation
New parts to control Donkeycar to stop at Stop Signs and swerve around traffic cones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like an interesting addition to the project. Do you have a video, or similar, where this can be seen in action? I only have minor comments to the code.
from tflite_support.task import processor | ||
from tflite_support.task import vision | ||
|
||
''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like commented code, can you remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
Removed extraneous code and unnecessary comments
Working on making a video. Expect to finish by Sunday. |
Remove the large files.
I am not clear why the MacOS.yml failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going to need changes to documentation for this. We have some docs on the current stop sign detector Stop Sign Detection; those will have to be changed. Can you open a parallel PR in the docs repository for the documentation changes? https://github.com/autorope/donkeydocs. For an example of what we are doing for docs in new features, see http://docs.donkeycar.com/guide/path_follow/path_follow/ and http://docs.donkeycar.com/guide/computer_vision/computer_vision/
I created a pull request for this part. See autorope/donkeydocs#51 |
I created two videos.... Stop Sign detection and Traffic Cone avoidance. And I added the video to the DonkeyDocs pull request |
Hello cfox570, how were you able to implement this into the donkeycar program? |
The pull request was attached to an older branch. Here is the code url. https://github.com/autorope/donkeycar/pull/1131/files. You will need to add the parts files and modify the complete template to implement. There is also a pull request to the documentation. See this link https://github.com/autorope/donkeydocs/pull/51/files |
New parts to control Donkeycar to stop at Stop Signs and swerve around traffic cones.