Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1075

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

salamisodikiolawale
Copy link

Add docker compose feature and update dockerfile with command RUN mkdir notebooks

@DocGarbanzo
Copy link
Contributor

@Heavy02011 - can you have a look at that?

Copy link
Contributor

@Ezward Ezward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest donkeycar release (5.x) requires python 3.9.x, so we should change the base image in the Dockerfile. Also there have been significant changes to how donkeycar is installed; there is no longer a setup.py. See https://docs.donkeycar.com/guide/host_pc/setup_ubuntu/#developer-install

@@ -0,0 +1,9 @@
version: '3.8'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: '3.8'
version: '3.9'

build: .
ports:
- "8887:8887"
- "8888:8888"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "8888:8888"
- "8888:8888"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants