Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dropbox recipe for supported_architectures #462

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −2
Open

Update dropbox recipe for supported_architectures #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions Dropbox/Dropbox.download.recipe
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,22 @@
<plist version="1.0">
<dict>
<key>Description</key>
<string>Downloads the current release version of Dropbox</string>
<string>Downloads the current release version of Dropbox

ARCHITECTURE
- x86_64 (default)
- arm64
</string>
<key>Identifier</key>
<string>com.github.autopkg.download.dropbox</string>
<key>Input</key>
<dict>
<key>NAME</key>
<string>Dropbox</string>
<key>ARCHITECTURE</key>
<string>x86_64</string>
<key>DOWNLOAD_URL</key>
<string>https://www.dropbox.com/download?plat=mac&amp;arch=%ARCHITECTURE%&amp;full=1</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does DOWNLOAD_URL need to be an input variable? I could see a rationale for adding a PLATFORM variable, but not the whole URL.

</dict>
<key>MinimumVersion</key>
<string>0.4.0</string>
Expand All @@ -19,7 +28,7 @@
<key>Arguments</key>
<dict>
<key>url</key>
<string>https://www.dropbox.com/download?plat=mac&amp;full=1</string>
<string>%DOWNLOAD_URL%</string>
<key>filename</key>
<string>%NAME%.dmg</string>
</dict>
Expand Down
8 changes: 8 additions & 0 deletions Dropbox/Dropbox.munki.recipe
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
<key>Description</key>
<string>Downloads the current release version of Dropbox and imports into Munki.

Use either x86_64 or arm64 for ARCHITECTURE key.

Postinstall script extracts the DropboxHelperInstaller and sets the setuid
bit so that it can perform its setup tasks as root without asking for admin
privileges.
Expand All @@ -22,6 +24,8 @@ to quit Dropbox.</string>
<string>com.github.autopkg.munki.dropbox</string>
<key>Input</key>
<dict>
<key>ARCHITECTURE</key>
<string>x86_64</string>
<key>MUNKI_REPO_SUBDIR</key>
<string>apps/Dropbox</string>
<key>NAME</key>
Expand All @@ -38,6 +42,10 @@ to quit Dropbox.</string>
<string>Dropbox</string>
<key>name</key>
<string>%NAME%</string>
<key>supported_architectures</key>
<array>
<string>%ARCHITECTURE%</string>
</array>
<key>postinstall_script</key>
<string>#!/bin/sh
# based on Ruby postinstall script by Riley Shott:
Expand Down