Update Grammarly.download.recipe #657
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is there a reason the recipe specifies CFBundleVersion rather than the default CFBundleShortVersionString? Jamf's Patch Management definition uses the shorter version so this throws out patching if Jamf Pro is used ... can it use the shorter string instead?
|
I don't remember the specifics, but it's likely at some point in the past that we saw a new version published that incremented the If that's no longer a concern, I'm open to merging this PR. However, changes need to be made in the Munki recipe that align with the changes in the Download recipe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a reason the recipe specifies CFBundleVersion rather than the default CFBundleShortVersionString? Jamf's Patch Management definition uses the shorter version so this throws out patching if Jamf Pro is used ... can it use the shorter string instead?