Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standard container tag for node #363

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

DaMandal0rian
Copy link
Contributor

@DaMandal0rian DaMandal0rian commented Nov 1, 2024

PR Type

enhancement


Description

  • Updated the environment variable from DOCKER_TAG to NODE_DOCKER_TAG in the .env file creation logic.
  • Applied changes to both nova and standard subql node configurations.
  • Ensured consistency in environment variable naming across different node configurations.

Changes walkthrough 📝

Relevant files
Enhancement
bootstrap_nova_subql_provisioner.tf
Update Docker tag environment variable for nova subql nodes

templates/terraform/subql/base/bootstrap_nova_subql_provisioner.tf

  • Changed environment variable DOCKER_TAG to NODE_DOCKER_TAG.
  • Updated .env file creation logic for nova-blue and nova-green subql
    nodes.
  • +2/-2     
    bootstrap_subql_provisioner.tf
    Update Docker tag environment variable for subql nodes     

    templates/terraform/subql/base/bootstrap_subql_provisioner.tf

  • Changed environment variable DOCKER_TAG to NODE_DOCKER_TAG.
  • Updated .env file creation logic for blue and green subql nodes.
  • +2/-2     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    github-actions bot commented Nov 1, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Consistency Check
    Ensure that the new environment variable naming convention does not conflict with other scripts or configurations that might still rely on the old DOCKER_TAG.

    Consistency Check
    Verify that the change from DOCKER_TAG to NODE_DOCKER_TAG is reflected across all relevant deployment scripts and documentation to maintain consistency.

    Copy link

    github-actions bot commented Nov 1, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @DaMandal0rian DaMandal0rian merged commit f9c2f9e into main Nov 1, 2024
    1 check passed
    @DaMandal0rian DaMandal0rian deleted the hotfix/change-tag-subql branch November 1, 2024 11:27
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants