fix variables in TF modules

[DaMandal0rian]

PR Type

enhancement, bug fix

---

Description

• Fixed a syntax error in the domain_labels variable default value in resources/taurus/variables.tf.
• Improved code readability by aligning the indentation of map entries in resources/taurus/variables.tf.
• Removed the unused rpc-indexer-node-config variable definition from templates/terraform/network-primitives/variables.tf.

---

Changes walkthrough 📝

	Relevant files
Bug fix	variables.tf Fix syntax and improve readability in variables file          resources/taurus/variables.tf Fixed syntax error in domain_labels default value. Aligned indentation for instance_type and instance_count maps. +16/-16
Enhancement	variables.tf Remove unused variable definition for RPC indexer node      templates/terraform/network-primitives/variables.tf Removed rpc-indexer-node-config variable definition. +0/-17

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Syntax Correction The correction of the default value syntax for domain_labels from a malformed string list to a proper list format is crucial to prevent runtime errors. Default Values The changes in default values for various instance types and counts need to be validated to ensure they align with expected configurations and do not introduce resource allocation issues.

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Ensure all necessary fields are included in the new variable configuration Ensure that the new rpc-node-config variable includes essential fields such as deployment-version and regions that were present in the removed rpc-indexer-node-config to maintain functionality. templates/terraform/network-primitives/variables.tf [100-101] instance-type = string +deployment-version = number +regions = list(string) Suggestion importance[1-10]: 8 Why: The suggestion highlights the omission of essential fields in the new rpc-node-config variable, which could lead to loss of functionality. This is a critical issue, and addressing it would maintain the intended functionality.	8
Possible bug	Adjust default instance counts to prevent service outages Consider setting non-zero default values for critical services like domain and nova-indexer to avoid potential service disruptions. resources/taurus/variables.tf [60-63] -domain = 0 -nova-indexer = 0 +domain = 1 +nova-indexer = 1 Suggestion importance[1-10]: 7 Why: The suggestion to set non-zero default values for critical services like domain and nova-indexer is relevant and could prevent potential service disruptions, making it a valuable improvement.	7
Enhancement	Review and optimize instance types for cost and resource efficiency Verify the consistency of instance types and ensure they are appropriate for their respective roles to optimize resource allocation and cost. resources/taurus/variables.tf [29-35] +bootstrap = "c7a.2xlarge" +rpc = "m7a.2xlarge" +domain = "m7a.2xlarge" +rpc-indexer = "c7a.4xlarge" +nova-indexer = "c7a.4xlarge" +farmer = "c7a.2xlarge" +evm_bootstrap = "c7a.xlarge" - Suggestion importance[1-10]: 5 Why: While the suggestion to verify and optimize instance types is valid, it is not directly actionable or specific. It provides a general recommendation without concrete changes, thus having a moderate impact.	5