You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add conditional checks to prevent deployment of resources when instance count is zero
Consider adding a conditional check for instance-count to ensure that configurations with a count of zero do not inadvertently deploy resources. This can prevent unnecessary cloud resource allocation and associated costs.
Why: Adding conditional checks for instance count is a strong suggestion for cost optimization, as it prevents unnecessary resource allocation and potential costs when the instance count is zero.
9
Maintainability
Use a variable for the docker tag to maintain consistency and simplify updates
Consider using a variable for the docker-tag to ensure consistency and ease of updates across different configurations. This approach will help maintain the docker tag version in one place and reduce the risk of discrepancies or errors during updates.
Why: Using a variable for the docker tag is a good practice for maintainability, as it centralizes the version control and reduces the risk of discrepancies across multiple configurations.
8
Security
Use a variable for the genesis hash to enhance security and flexibility
To avoid hardcoding the genesis-hash, consider using a variable or a secure method to inject this value, enhancing the security and flexibility of the configuration.
Why: Using a variable for the genesis hash enhances security by avoiding hardcoding sensitive information, and increases flexibility for future changes.
8
Best practice
Manage the deployment version through a variable for better version control
Ensure that the deployment-version is updated or managed through a variable if the deployment process is versioned. This can help in tracking and managing different deployment stages or versions systematically.
Why: Managing the deployment version through a variable can improve version control and tracking, especially if the deployment process is versioned, although it may not be as critical if the version is static.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
enhancement
Description
docker-tag
for various configurations inmain.tf
to "gemini-3h-2024-sep-17".rpc
anddomain
to "m7a.2xlarge" invariables.tf
.bootstrap
,domain
,autoid
,nova-squid
,evm_bootstrap
, andautoid_bootstrap
to 0 invariables.tf
.Changes walkthrough 📝
main.tf
Update Docker tag for Gemini-3h configurations
resources/gemini-3h/main.tf
docker-tag
to "gemini-3h-2024-sep-17" for multipleconfigurations.
variables.tf
Modify instance types and counts for Gemini-3h
resources/gemini-3h/variables.tf
rpc
anddomain
to "m7a.2xlarge".