Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set farming-thread-pool-size for farmer #338

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

DaMandal0rian
Copy link
Contributor

@DaMandal0rian DaMandal0rian commented Sep 18, 2024

PR Type

enhancement


Description

  • Added a new parameter --farming-thread-pool-size with a value of "4" to the farmer node configuration in both the shell script and the Docker Compose file.
  • Removed obsolete parameters --farm-during-initial-plotting and --plotting-thread-pool-size from the Docker Compose file.

Changes walkthrough 📝

Relevant files
Enhancement
create_farmer_node_compose_file.sh
Add farming thread pool size parameter to farmer node       

templates/scripts/create_farmer_node_compose_file.sh

  • Added --farming-thread-pool-size parameter with a value of "4".
+1/-0     
docker-compose-farmer.yml
Update farmer node configuration with new thread pool size

ansible/network/files/docker-compose-farmer.yml

  • Added --farming-thread-pool-size parameter with a value of "4".
  • Removed --farm-during-initial-plotting and --plotting-thread-pool-size
    parameters.
  • +1/-2     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    Copy link

    github-actions bot commented Sep 18, 2024

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Enhancement
    Parameterize the farming thread pool size to enhance configurability

    Consider parameterizing the --farming-thread-pool-size value to allow easy
    configuration changes without modifying the script directly. This can be done by
    using an environment variable.

    templates/scripts/create_farmer_node_compose_file.sh [76]

    -"--farming-thread-pool-size", "4",
    +"--farming-thread-pool-size", "${FARMING_THREAD_POOL_SIZE}",
     
    Suggestion importance[1-10]: 8

    Why: Parameterizing the farming thread pool size allows for greater flexibility and easier configuration changes without modifying the script directly, which is a significant improvement in terms of maintainability and usability.

    8

    @DaMandal0rian DaMandal0rian merged commit 2880bb2 into main Sep 18, 2024
    2 checks passed
    @DaMandal0rian DaMandal0rian deleted the farmer-changes branch September 18, 2024 12:25
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants